Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-55987

Gradebook calculation may need a lot of memory

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 3.1
    • 3.0.7, 3.1.3
    • Gradebook
    • MOODLE_31_STABLE
    • MOODLE_30_STABLE, MOODLE_31_STABLE
    • MDL-55987-master-grademem
    • Hide

      To tester: the priority here is just to test for accidental regressions because the change is straight forward. If time does not allow, a small dataset will be sufficient.

      This has been tested intensively during the debugging on moodle.org staging copy. This can be tested e.g. by having a course with many users (like several thousands) and adding a graded activity into a course. That is one of the ways to trigger the gradebook update.

      Show
      To tester: the priority here is just to test for accidental regressions because the change is straight forward. If time does not allow, a small dataset will be sufficient. This has been tested intensively during the debugging on moodle.org staging copy. This can be tested e.g. by having a course with many users (like several thousands) and adding a graded activity into a course. That is one of the ways to trigger the gradebook update.

    Description

      In MDL-49332, emerrill raised time limits for final grades calculations. As we learnt at moodle.org, in a course with 7500 students and 70 graded activities, the memory may easily become problem, too.

      This has significant impact as there is no way to add a graded activity to the course or access the gradebook, for example.

      The full story of how we experienced this on moodle.org and how we tracked it down can be seen in MDLSITE-4750. Shortly, we needed to add raise_memory_limit(MEMORY_EXTRA); to grade_regrade_final_grades() to make the site usable again. It seems like reasonable step to have this in the core.

      Attachments

        1. screenshot-1.png
          screenshot-1.png
          44 kB
        2. screenshot-2.png
          screenshot-2.png
          84 kB
        3. screenshot-3.png
          screenshot-3.png
          64 kB
        4. screenshot-4.png
          screenshot-4.png
          73 kB
        5. screenshot-5.png
          screenshot-5.png
          49 kB

        Issue Links

          has a non-specific relationship to

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-49332 Gradebook calculation may timeout

          • Critical - Crashes server, loss of data, severe memory leak
          • Closed

          Task - A task that needs to be completed. Tasks usually refer to work that must be done outside the product. MDL-56132 Investigate potential usage of MYSQLI_STORE_RESULT_COPY_DATA mode in get_recordset_sql()

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Activity

            People

              mudrd8mz David Mudrák (@mudrd8mz)
              mudrd8mz David Mudrák (@mudrd8mz)
              Eric Merrill Eric Merrill
              Dan Poltawski Dan Poltawski
              Jake Dallimore Jake Dallimore
              Adrian Greeve, Ilya Tregubov, Kevin Percy, Mathew May, Mihail Geshoski, Shamim Rezaie
              Votes:
              1 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                14/Nov/16