Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-56000

Upgrade PHPMailer to 5.2.16 for Moodle 3.2 release

    Details

    • Type: Task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.2
    • Fix Version/s: 3.2
    • Component/s: Libraries
    • Labels:
    • Testing Instructions:
      Hide
      1. Setup email in your moodle instance
      2. Create some users with valid emails
      3. Do some actions that results in sending of emails (forgotten password, send message, etc.)
      4. Verify emails are received at the accounts specified in 2.

      Tip: If it fails, you can use email debugging to get messages from PHPMailer.

      • Please also check the third party library list at [Site administration  ► Development  ► Third party libraries] to ensure that the version number is correct.
      Show
      Setup email in your moodle instance Create some users with valid emails Do some actions that results in sending of emails (forgotten password, send message, etc.) Verify emails are received at the accounts specified in 2. Tip: If it fails, you can use email debugging to get messages from PHPMailer. Please also check the third party library list at [Site administration  ► Development  ► Third party libraries] to ensure that the version number is correct.
    • Affected Branches:
      MOODLE_32_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE
    • Epic Link:
    • Pull from Repository:
    • Pull Master Branch:
      MDL-56000-master
    • Sprint:
      3.2 Sprint 6
    • Sprint:
      3.2 Sprint 6

      Description

      see parent epic and previous issues

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              Hide
              cibot CiBoT added a comment -

              Code verified against automated checks.

              Checked MDL-56000 using repository: git://github.com/lameze/moodle.git

              More information about this report

              Show
              cibot CiBoT added a comment - Code verified against automated checks. Checked MDL-56000 using repository: git://github.com/lameze/moodle.git master (0 errors / 0 warnings) [branch: MDL-56000-master | CI Job ] More information about this report
              Hide
              marina Marina Glancy added a comment -

              Check list for the library upgrade peer review:

              • library is updated
              • Unittests pass (check Travis results)
              • respective thirdpartylibs.xml is updated with the correct version
              • readme_moodle.txt is updated with the correct version and/or changes made
              • all hacks described in readme_moodle.txt are re-applied (preferably as a separate commit)
              • dev_docs_required label is added with a reminder to update https://docs.moodle.org/dev/Moodle_libraries_credits when issue is integrated

              P.S. This is a message sent as part of bulk action to all open issues with libraries upgrade. This list applies to the majority of libraries however may be 100% correct for this particular issue

              Show
              marina Marina Glancy added a comment - Check list for the library upgrade peer review: library is updated Unittests pass (check Travis results) respective thirdpartylibs.xml is updated with the correct version readme_moodle.txt is updated with the correct version and/or changes made all hacks described in readme_moodle.txt are re-applied (preferably as a separate commit) dev_docs_required label is added with a reminder to update https://docs.moodle.org/dev/Moodle_libraries_credits when issue is integrated P.S. This is a message sent as part of bulk action to all open issues with libraries upgrade. This list applies to the majority of libraries however may be 100% correct for this particular issue
              Hide
              marina Marina Glancy added a comment -

              Adding label dev_docs_required - please don't forget to update https://docs.moodle.org/dev/Moodle_libraries_credits when issue is integrated and remove this label

              Show
              marina Marina Glancy added a comment - Adding label dev_docs_required - please don't forget to update https://docs.moodle.org/dev/Moodle_libraries_credits when issue is integrated and remove this label
              Hide
              jaked Jake Dallimore added a comment -

              Hi Simey,
              The upgrade looks good to me. Feel free to push for integration

              Show
              jaked Jake Dallimore added a comment - Hi Simey, The upgrade looks good to me. Feel free to push for integration
              Hide
              lameze Simey Lameze added a comment -

              Thanks for the review Jake, I'm sending for integration review now.

              Show
              lameze Simey Lameze added a comment - Thanks for the review Jake, I'm sending for integration review now.
              Hide
              cibot CiBoT added a comment -

              Code verified against automated checks.

              Checked MDL-56000 using repository: git://github.com/lameze/moodle.git

              More information about this report

              Show
              cibot CiBoT added a comment - Code verified against automated checks. Checked MDL-56000 using repository: git://github.com/lameze/moodle.git master (0 errors / 0 warnings) [branch: MDL-56000-master | CI Job ] More information about this report
              Hide
              cibot CiBoT added a comment -

              Moving this issue to current integration cycle, will be reviewed soon. Thanks for the hard work!

              Show
              cibot CiBoT added a comment - Moving this issue to current integration cycle, will be reviewed soon. Thanks for the hard work!
              Hide
              cibot CiBoT added a comment -

              Code verified against automated checks.

              Checked MDL-56000 using repository: git://github.com/lameze/moodle.git

              More information about this report

              Show
              cibot CiBoT added a comment - Code verified against automated checks. Checked MDL-56000 using repository: git://github.com/lameze/moodle.git master (0 errors / 0 warnings) [branch: MDL-56000-master | CI Job ] More information about this report
              Hide
              dobedobedoh Andrew Nicols added a comment -

              Thanks Simey,

              Those changes look good and I've integrated them now.

              Quick summary of the changes between 5.2.14 and 5.2.16:

              5.2.15
              • Added ability to inject custom address validators, and set the default validator
              • Fixed TLS 1.2 compatibility
              • Improved examples
              • Improved Windows compatibility
              • Upgraded DKIM signing to use SHA-2 hashes
              • Fixed gmail XOAUTH2 scope
              h5.2.16
              • Added DKIM example
              • Fixed empty additional_parameters problem
              • Fixed wrong version number in VERSION file!
              • Improve line-length tests
              • Use instance settings in smtpConnect by default
              • Use more secure auth mechanisms first

              Integrated to master only. Over to testing.

              Show
              dobedobedoh Andrew Nicols added a comment - Thanks Simey, Those changes look good and I've integrated them now. Quick summary of the changes between 5.2.14 and 5.2.16: 5.2.15 Added ability to inject custom address validators, and set the default validator Fixed TLS 1.2 compatibility Improved examples Improved Windows compatibility Upgraded DKIM signing to use SHA-2 hashes Fixed gmail XOAUTH2 scope h5.2.16 Added DKIM example Fixed empty additional_parameters problem Fixed wrong version number in VERSION file! Improve line-length tests Use instance settings in smtpConnect by default Use more secure auth mechanisms first Integrated to master only. Over to testing.
              Hide
              marina Marina Glancy added a comment -

              Thanks Simey, testing passed, email was received

              Show
              marina Marina Glancy added a comment - Thanks Simey, testing passed, email was received
              Hide
              stronk7 Eloy Lafuente (stronk7) added a comment -

              And this, now, can be safely closed, while Moodle's hordes start using it! Many, many thanks!

              "I don't know half of you half as well as I should like; and I like
              less than half of you half as well as you deserve."
              — J.R.R. Tolkien

              Show
              stronk7 Eloy Lafuente (stronk7) added a comment - And this, now, can be safely closed, while Moodle's hordes start using it! Many, many thanks! "I don't know half of you half as well as I should like; and I like less than half of you half as well as you deserve." — J.R.R. Tolkien
              Hide
              stronk7 Eloy Lafuente (stronk7) added a comment -

              Just to comment about MDL-57474 (originally reported as MDLSITE) that seems to point that the PHPMailer upgrade came with a regression breaking/eating our "Message-ID" headers.

              Show
              stronk7 Eloy Lafuente (stronk7) added a comment - Just to comment about MDL-57474 (originally reported as MDLSITE) that seems to point that the PHPMailer upgrade came with a regression breaking/eating our "Message-ID" headers.

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  5 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    5/Dec/16