[MDL-56035] Fix last usability issues & small bugs - Moodle Tracker

XML

Word

Printable

Affected Branches:
MOODLE_32_STABLE
Pull from Repository:
https://github.com/xow/moodle.git
Pull Master Branch:
~~MDL-56035~~-master
Pull Master Diff URL:
https://github.com/xow/moodle/compare/8df83559a0b5fddd7b095a2d993f42f1c50eb28e...MDL-56035-master

~~Remove enrol_lti_item table~~
~~Use $this->user->image for user_image~~
~~Make sure 'failed registration’ language string isn’t used for launches.~~
~~Should we save tool proxy to the db?~~ No
~~Register a user as student when role is incorrect or not sent (what happens currently? It just says Sorry, there was an error connecting you to the application.)~~
~~Make a nicer error message if no resource_link_id is given~~
~~Most errors are not using notification API (wrong url, wrong parameters)~~ mod_lti is doing this. No need to fix
Fix bug where enrol_lti_lti2_nonce is not working without auto increment id.
to avoid an error unknown error fetching inserted id I have to and id autoincrement
Unable to reproduce
~~Fix all code style errors that have snuck through~~
~~If no return url is given, it should still work (add unit test to cover this)~~ - Required in spec
~~Fix todos~~

has a non-specific relationship to

MDL-37041 The LTI consumer does not pass the user's profile picture in the user_image launch parameter

MDL-55442 Certificate the LTI Provider plugin

is blocked by

MDL-55647 Add unit tests for enrol_lti for the way we use the new library

Component watchers:: David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo, David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo