Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-56042

RTL flip is not applied when there aren't any post processor

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 3.2
    • Fix Version/s: 3.2
    • Component/s: Themes
    • Labels:
    • Testing Instructions:
      Hide
      1. Switch to theme_boost
      2. Open its config file and comment

        $THEME->csstreepostprocessor = 'theme_boost_css_tree_post_processor';
        

      3. Swtich to RTL and confirm that the blocks, user menu, etc... are flipped to the opposite side compared with LTR
      4. Uncomment the line above and refresh
      5. Confirm that the styles remained flipped for RTL
      6. Confirm that the main rule for HR contains two box-sizing definition, one of which is prefixed for webkit (you'll have to inspect the CSS file)
      7. Switch back to English
      8. Confirm again that box-sizing is being prefixed.
      Show
      Switch to theme_boost Open its config file and comment $THEME->csstreepostprocessor = 'theme_boost_css_tree_post_processor'; Swtich to RTL and confirm that the blocks, user menu, etc... are flipped to the opposite side compared with LTR Uncomment the line above and refresh Confirm that the styles remained flipped for RTL Confirm that the main rule for HR contains two box-sizing definition, one of which is prefixed for webkit (you'll have to inspect the CSS file) Switch back to English Confirm again that box-sizing is being prefixed.
    • Affected Branches:
      MOODLE_32_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-56042-master

      Description

      This is a bug which I had fixed somewhere but it must have gotten lost in one of my branches. The logic determining whether we should RTLize the CSS and the post processor can conflict and cause the RTL not to flip.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                fred Frédéric Massart
                Reporter:
                fred Frédéric Massart
                Integrator:
                Dan Poltawski
                Tester:
                Dan Poltawski
                Participants:
                Component watchers:
                Amaia Anabitarte, Bas Brands, Carlos Escobedo, Sara Arjona (@sarjona), Víctor Déniz Falcón
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  5/Dec/16