Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-56057

Manage global search page incorrectly reports search areas as disabled in a new 3.2 site

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.2
    • Fix Version/s: 3.2
    • Component/s: Global search
    • Labels:
    • Testing Instructions:
      Hide
      1. Install a new site
      2. Go to admin/settings.php?section=manageglobalsearch
      3. Ensure "Enable search areas" is set to 'yes' by default
      4. Go to admin/searchareas.php and disable them all
      5. Return to admin/settings.php?section=manageglobalsearch and confirm that now "Enable search areas" have a red 'no'
      6. Return to admin/searchareas.php and enable one of them
      7. Return to admin/settings.php?section=manageglobalsearch and confirm that now "Enable search areas" have a green 'yes' again
      Show
      Install a new site Go to admin/settings.php?section=manageglobalsearch Ensure "Enable search areas" is set to 'yes' by default Go to admin/searchareas.php and disable them all Return to admin/settings.php?section=manageglobalsearch and confirm that now "Enable search areas" have a red 'no' Return to admin/searchareas.php and enable one of them Return to admin/settings.php?section=manageglobalsearch and confirm that now "Enable search areas" have a green 'yes' again
    • Affected Branches:
      MOODLE_32_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-56057_master

      Description

      The problem is that enabled search areas are not a standard admin_setting any more, the API defaults to enabled if there is no value and it is working properly, but admin_setting_searchsetupinfo page (admin/settings.php?section=manageglobalsearch) reports it incorrectly as it is checking directly the var's contents.

      This is a regression introduced in MDL-53222.

        Attachments

          Activity

            People

            Assignee:
            dmonllao David Monllaó
            Reporter:
            dmonllao David Monllaó
            Peer reviewer:
            Simey Lameze
            Integrator:
            Eloy Lafuente (stronk7)
            Tester:
            Jun Pataleta
            Participants:
            Component watchers:
            Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              5/Dec/16