[MDL-56061] theme_boost is using REM units, but CSS coding style advises against it - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.2
Fix Version/s: 3.2
Component/s: Themes
Labels:
- ci
- triaged

Affected Branches:
MOODLE_32_STABLE
Fixed Branches:
MOODLE_32_STABLE
Epic Link:
Theme and Nav changes for 3.2
Pull from Repository:
git://github.com/FMCorz/moodle.git
Pull Master Branch:
~~MDL-56061~~-master
Pull Master Diff URL:
https://github.com/FMCorz/moodle/compare/1f2744851f...MDL-56061-master
Testing Instructions:
1. Confirm that REM is not a blacklisted unit
2. Run grunt stylelint and confirm that there aren't any warnings

Description

Either we need to revise the CSS coding style (and .stylelintrc) or update the code

Attachments

Issue Links

Discovered while testing

MDL-55071 New "Boost" Bootstrap 4 theme

Closed

Activity

People

Assignee:: Frédéric Massart

Reporter:: Dan Poltawski

Peer reviewer:: Damyon Wiese

Participants:: CiBoT, Damyon Wiese, Dan Poltawski, Frédéric Massart

Component watchers:: Huong Nguyen, Bas Brands, Mathew May, Amaia Anabitarte, Carlos Escobedo, Laurent David, Mikel Martín Corrales, Sabina Abellan, Sara Arjona (@sarjona)

Votes:: 0 Vote for this issue

Watchers:: 3 Start watching this issue

Dates

Created:: 22/Sep/16 5:57 AM

Updated:: 23/Sep/16 11:16 PM

Resolved:: 23/Sep/16 11:16 PM

Fix Release Date:: 5/Dec/16