Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-56062

Use configured number of decimal places when displaying grades

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.1.2
    • Fix Version/s: 3.0.7, 3.1.3
    • Component/s: Assignment
    • Labels:
    • Testing Instructions:
      Hide
      1. Change the admin setting $CFG->grade_decimalpoints (Site administration ► Grades ► Grade item settings -> Overall decimal points) to 3.
      2. Create an assignment with a numeric grading scheme. Make sure to tick Offline grading worksheet under Feedback types.
      3. Click Save and display
      4. On the assignment's page, click View all submissions
      5. Under Grading action select Download grading worksheet
      6. Open the CSV file using a text editor.
      7. Check the values for the column under "Maximum Grade"
        • Confirm that the values are formatted with 3 decimal places (e.g. 100.000).
      8. Set Grades for some of the students and save the CSV file.
      9. Back on the assignment's grading table page, select Upload grading worksheet.
      10. Upload the modified CSV file.
      11. Check the grades displayed under Confirm changes in grading worksheet
        • Confirm that the grades are displayed with 3 decimal places.
      12. Confirm the changes and click Continue to go back to the grading table.
        • On the grading table, confirm that the grades are displayed with 3 decimal places.
      13. Under the Options section, tick Quick grading.
        • Confirm that the grades are displayed with 3 decimal places.
      14. Click Grade on one of the students that already have a grade.
      15. Check the text field beside Grade out of 100.
        • Confirm that the grade is displayed with 3 decimal places.
      16. If on 31 and master, go to the old grading page (mod/assign/view.php?id=ASSIGNMENT_ID&action=grade).
      17. Check the text field beside Grade out of 100.
        • Confirm that the grade is displayed with 3 decimal places.
      18. Login as a student whose assignment has already been graded.
      19. Go to the assignment's page.
        • Confirm that the grade and the maximum grade are displayed with 3 decimal places.
      20. Login as a teacher again and return to the course page.
      21. Click Course administration -> Gradebook setup and select Course grade settings from the menu.
      22. Under Grade item settings change Overall decimal points to 4 and save the changes.
      23. Return to the assignment page.
      24. Repeat steps 4 to 19 above and verify that all grades are now displayed with 4 decimal places.
      Show
      Change the admin setting $CFG->grade_decimalpoints ( Site administration ► Grades ► Grade item settings -> Overall decimal points ) to 3. Create an assignment with a numeric grading scheme. Make sure to tick Offline grading worksheet under Feedback types . Click Save and display On the assignment's page, click View all submissions Under Grading action select Download grading worksheet Open the CSV file using a text editor. Check the values for the column under "Maximum Grade" Confirm that the values are formatted with 3 decimal places (e.g. 100.000). Set Grades for some of the students and save the CSV file. Back on the assignment's grading table page, select Upload grading worksheet . Upload the modified CSV file. Check the grades displayed under Confirm changes in grading worksheet Confirm that the grades are displayed with 3 decimal places. Confirm the changes and click Continue to go back to the grading table. On the grading table, confirm that the grades are displayed with 3 decimal places. Under the Options section, tick Quick grading . Confirm that the grades are displayed with 3 decimal places. Click Grade on one of the students that already have a grade. Check the text field beside Grade out of 100 . Confirm that the grade is displayed with 3 decimal places. If on 31 and master, go to the old grading page ( mod/assign/view.php?id=ASSIGNMENT_ID&action=grade ). Check the text field beside Grade out of 100 . Confirm that the grade is displayed with 3 decimal places. Login as a student whose assignment has already been graded. Go to the assignment's page. Confirm that the grade and the maximum grade are displayed with 3 decimal places. Login as a teacher again and return to the course page. Click Course administration -> Gradebook setup and select Course grade settings from the menu. Under Grade item settings change Overall decimal points to 4 and save the changes. Return to the assignment page. Repeat steps 4 to 19 above and verify that all grades are now displayed with 4 decimal places.
    • Affected Branches:
      MOODLE_31_STABLE
    • Fixed Branches:
      MOODLE_30_STABLE, MOODLE_31_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-56062-master

      Description

      $CFG->grade_decimalpoints seems to have been missed out in several places in the mod_assign locallib.php code.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              tonybutler Tony Butler
              Reporter:
              tonybutler Tony Butler
              Peer reviewer:
              Jun Pataleta
              Integrator:
              Dan Poltawski
              Tester:
              Jake Dallimore
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                14/Nov/16