[MDL-56063] Review theme_boost !important uses - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.2
Fix Version/s: 3.2
Component/s: Themes
Labels:
- ci
- triaged

Affected Branches:
MOODLE_32_STABLE
Fixed Branches:
MOODLE_32_STABLE
Epic Link:
Theme and Nav changes for 3.2
Pull from Repository:
git://github.com/FMCorz/moodle.git
Pull Master Branch:
~~MDL-56063~~-master
Pull Master Diff URL:
https://github.com/FMCorz/moodle/compare/317fc976d2...MDL-56063-master
Testing Instructions:
1. Run grunt stylelint and confirm that there aren't any errors

Description

Since we're on a brand new theme, we should be free of !important hacks. This issue is to review each !imporant use - justify it with a comment and a stylelint-ignore line, or remove the use.

Attachments

Issue Links

Testing discovered

MDL-56095 Progress bar not visible in Boost

Closed

Activity

People

Assignee:: Frédéric Massart

Reporter:: Dan Poltawski

Peer reviewer:: Dan Poltawski

Integrator:: Dan Poltawski

Tester:: Dan Poltawski

Participants:: CiBoT, Dan Poltawski, Eloy Lafuente (stronk7), Frédéric Massart

Component watchers:: Huong Nguyen, Bas Brands, Mathew May, Amaia Anabitarte, Carlos Escobedo, Laurent David, Mikel Martín Corrales, Sabina Abellan, Sara Arjona (@sarjona)

Votes:: 0 Vote for this issue

Watchers:: 2 Start watching this issue

Dates

Created:: 22/Sep/16 6:13 AM

Updated:: 30/Sep/16 7:21 AM

Resolved:: 30/Sep/16 7:21 AM

Fix Release Date:: 5/Dec/16