[MDL-56097] Update upgrade_stale_php_files_present() before 3.2 release - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.2
Fix Version/s: 3.2
Component/s: Installation
Labels:
- ci
- triaged

Affected Branches:
MOODLE_32_STABLE
Fixed Branches:
MOODLE_32_STABLE
Pull from Repository:
git://github.com/stronk7/moodle.git
Pull Main Branch:
~~MDL-56097~~
Pull Main Diff URL:
https://github.com/stronk7/moodle/compare/master...MDL-56097
Testing Instructions:
Hide

web

Create and install a 3.1.x site.

Check out a master site on the just installed site. Before upgrading, touch any of the files that are being detected in the patch, so they exist:

/calendar/preferences.php

/lib/jquery/jquery-1.12.1.min.js

...

Do a web based upgrade to master.

A notice should be displayed saying that there are problems upgrading and a proper procedure for upgrading to a major release.

Delete the touched file and refresh.

Ensure that the upgrade now will proceed.

cli

Disclaimer: CLI upgrade does not run the upgrade_stale_php_files_present() check. ~~MDL-53596~~ has been created about that. Nothing to test here yet.
Show
web Create and install a 3.1.x site. Check out a master site on the just installed site. Before upgrading, touch any of the files that are being detected in the patch, so they exist: /calendar/preferences.php /lib/jquery/jquery-1.12.1.min.js ... Do a web based upgrade to master. A notice should be displayed saying that there are problems upgrading and a proper procedure for upgrading to a major release. Delete the touched file and refresh. Ensure that the upgrade now will proceed. cli Disclaimer: CLI upgrade does not run the upgrade_stale_php_files_present() check. MDL-53596 has been created about that. Nothing to test here yet.

Description

Simply verify we have a number (4-5) of files for the next major release. They all must be files deleted since last stable version and current master

git diff --name-status MOODLE_XX_STABLE..master | grep ^D

Note that it's better not to pick any plugin file that maybe reinstalled manually (exception being forum files because that plugin is mandatory).

Attachments

Issue Links

has a non-specific relationship to

MDL-53596 Make CLI upgrade to verify upgrade_stale_php_files_present()

Closed

Activity

People

Assignee:: Eloy Lafuente (stronk7)

Reporter:: Eloy Lafuente (stronk7)

Peer reviewer:: Frédéric Massart

Integrator:: David Monllaó

Tester:: Adrian Greeve

Participants:: Adrian Greeve, CiBoT, David Monllaó, Eloy Lafuente (stronk7), Frédéric Massart, Russell Smith

Votes:: 0 Vote for this issue

Watchers:: 3 Start watching this issue

Dates

Created:: 23/Sep/16 2:16 PM

Updated:: 14/Oct/16 3:47 PM

Resolved:: 14/Oct/16 3:47 PM

Fix Release Date:: 5/Dec/16