[MDL-56102] LTI enrolment unit test has unreached code - Moodle Tracker

XML

Word

Printable

Testing Instructions:
Hide

Run PHPUnit

vendor/bin/phpunit --testsuite enrol_lti_testsuite

or if using MDK,

mdk phpunit -r -s enrol_lti

Confirm that there are no errors nor failures.
Show
Run PHPUnit vendor/bin/phpunit --testsuite enrol_lti_testsuite or if using MDK, mdk phpunit -r -s enrol_lti Confirm that there are no errors nor failures.
Affected Branches:
MOODLE_32_STABLE
Fixed Branches:
MOODLE_32_STABLE
Pull from Repository:
https://github.com/xow/moodle.git
Pull Master Branch:
~~MDL-56102~~-master
Pull Master Diff URL:
https://github.com/xow/moodle/compare/26162efe4a...MDL-56102-master

In my unit test I accidentally left a couple lines after the expected exception is thrown

Not a huge priority because once the exception is thrown the execution leaves, but it does give off annoying errors in IDEs, and is bad example code

is a regression caused by

MDL-54680 Offer cartridges in LTI provider

Participants:: CiBoT, Dan Poltawski, Eloy Lafuente (stronk7), Jake Dallimore, John Okely

Component watchers:: Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona), Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan