Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-56102

LTI enrolment unit test has unreached code

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Run PHPUnit 

         vendor/bin/phpunit --testsuite enrol_lti_testsuite

        or if using MDK,

        mdk phpunit -r -s enrol_lti

        • Confirm that there are no errors nor failures.
      Show
      Run PHPUnit vendor/bin/phpunit --testsuite enrol_lti_testsuite or if using MDK, mdk phpunit -r -s enrol_lti Confirm that there are no errors nor failures.
    • Affected Branches:
      MOODLE_32_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-56102-master
    • Pull Master Diff URL:

      Description

      In my unit test I accidentally left a couple lines after the expected exception is thrown

      Not a huge priority because once the exception is thrown the execution leaves, but it does give off annoying errors in IDEs, and is bad example code

        Attachments

          Issue Links

          is a regression caused by

          Improvement - An enhancement to an existing Moodle feature. MDL-54680 Offer cartridges in LTI provider

          • Minor - Minor loss of function where workaround is possible
          • Closed

            Activity

              People

              Assignee:
              johno John Okely
              Reporter:
              johno John Okely
              Peer reviewer:
              Jake Dallimore Jake Dallimore
              Integrator:
              Dan Poltawski Dan Poltawski
              Tester:
              Dan Poltawski Dan Poltawski
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona), Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                5/Dec/16