-
Bug
-
Resolution: Won't Do
-
Minor
-
None
-
3.0.6
-
MOODLE_30_STABLE
The mform->disabledIf adds the 'disabled' attribute to form fields when another items state changes.
For filepickers, it adds this to the hidden field as expected, but for the button that lets you add files, it appears to only add a .disabled class, which then is used to style the button as greyed out, and allow some JS to stop the button from working.
It's not clear why the disabled attribute is not used for the button, but it seems intentional as there appears to be code that did this in the past. MDL-26167 looks like it adds the code I would have expected, but the code has changed since then.
edit: MDL-34221 seems to be where it was removed again. It would seem a combination of the two bits of code would be best, using the class to do all the other things, but using the disabled attribute to disable the button properly, rather than fake it.
I noticed this on the Manage Calendar page:
/calendar/managesubscriptions.php
But I believe it's a generic problem to anywhere this is used in mforms.
I think this is both an accessibility issue, and causes styling issues as the disabled button won't look like "real" disabled buttons, doubly so if people take advantage of the styling opportunities in the new BS4 theme.
- has a non-specific relationship to
-
MDL-29421 Form elements editor does not support freezing
-
- Waiting for peer review
-