Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-56118

RTL auto-flipping shouldn't cause an increase in CSS size served to users

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Not a bug
    • 3.2
    • None
    • Themes

    Description

      From David's review:

      https://github.com/damyon/moodle/compare/MDL-55071-master~142...MDL-55071-master#diff-35b4a816e0441e6a375cd925af50752cR146 We need to justify this change for theme_clean user. Even if browsers cache it, tt is around a 15% increment in the file size. I haven't found any justification in MDL-55377

      The link is broken now and I haven't investigated properly - so I just wanted to crease this issue to ensure that the production CSS sent to users does get minified. There is no need that we have to accept larger asset size for users just to support auto-flipping.

      Attachments

        Issue Links

          Discovered while testing

          New Feature - A new Moodle feature which has yet to be developed. MDL-55071 New "Boost" Bootstrap 4 theme

          • Blocker - Blocks development and/or testing, prevents Moodle from running (applicable to bugs only)
          • Closed
          has a non-specific relationship to

          Task - A task that needs to be completed. Tasks usually refer to work that must be done outside the product. MDL-53695 Replace mrclay/minify with matthiasmullie/minify

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Activity

            People

              Unassigned Unassigned
              poltawski Dan Poltawski
              Huong Nguyen, Bas Brands, Mathew May
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: