Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-56133

Changes in lang pack not visible after update_langpacks_task

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      With any developer mode stuff turned off:

      1. Download a language pack (you can do it through moodle's UI if you'd like)
      2. Find a string you know the display location of and modify it
      3. Purge caches and browse to the page where the string is displayed
      4. Confirm it is the modified version
      5. Edit the file [yourmoodledatadir]/lang/[langcode]/[langcode].md5 - just modify a few letters/numbers
      6. Run: php admin/tool/task/cli/schedule_task.php --execute=\\tool_langimport\\task
        update_langpacks_task
        from the command line
      7. Refresh the page and verify that the string has reverted back to what it looked like before you modified it
      Show
      With any developer mode stuff turned off : Download a language pack (you can do it through moodle's UI if you'd like) Find a string you know the display location of and modify it Purge caches and browse to the page where the string is displayed Confirm it is the modified version Edit the file [yourmoodledatadir]/lang/[langcode]/[langcode].md5 - just modify a few letters/numbers Run: php admin/tool/task/cli/schedule_task.php --execute=\\tool_langimport\\task update_langpacks_task from the command line Refresh the page and verify that the string has reverted back to what it looked like before you modified it
    • Affected Branches:
      MOODLE_31_STABLE
    • Fixed Branches:
      MOODLE_30_STABLE, MOODLE_31_STABLE
    • Pull from Repository:
    • Pull Master Branch:

      Description

      Looks like the scheduled task update_langpacks_task does not purge language cache.
      Because of this, changes in updated language packs are not visible.

      Steps
      1. Change string in official language pack(not english)
      2. Run php schedule_task.php --execute=\\tool_langimport\\task
      update_langpacks_task
      3. Verify that new language pack was downloaded and the translated string is present
      4. Translated string is not visible in moodle, old value is presented
      5. Run php admin/cli/purge_caches.php
      6. New value of the string is presented in the moodle.

        Attachments

          Activity

            People

            • Assignee:
              nmagill Neill Magill
              Reporter:
              grzesiek Grzegorz Ziółek
              Peer reviewer:
              Dan Poltawski
              Integrator:
              David Monllaó
              Tester:
              cameron1729
              Participants:
              Component watchers:
              Matteo Scaramuccia, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón, cameron1729, David Mudrák (@mudrd8mz), Helen Foster, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón
            • Votes:
              2 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                14/Nov/16