Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-56228

PHPUnit failure on Oracle due to erroneous default sorting

    XMLWordPrintable

Details

    • MOODLE_32_STABLE
    • MOODLE_32_STABLE
    • MDL-56228-master
    • Hide

      This is just a simple regression test

      1. Set up oracle docker instance and the the oracle oci driver for php (see here for Ubuntu derivatives )
      2. Run the following test a few times and make sure it passes (no regression) 

        vendor/bin/phpunit mod_data_generator_testcase mod/data/tests/generator_test.php

      Show
      This is just a simple regression test Set up oracle docker instance and the the oracle oci driver for php ( see here for Ubuntu derivatives ) Run the following test a few times and make sure it passes (no regression) vendor/bin/phpunit mod_data_generator_testcase mod/data/tests/generator_test.php

    Description

      Testing a library upgrade, I came across this failure (using the moodle oracle docker instance):

      There was 1 failure:
      		 
       
      		 
      1) mod_data_generator_testcase::test_create_entry
      		 
      Failed asserting that two strings are equal.
      		 
      --- Expected
      		 
      +++ Actual
      		 
      @@ @@
      		 
      -'menu1'
      		 
      +'opt1##opt2##opt3##opt4'
      		 
       
      		 
      /home/jake/moodledata/omaster/moodle/mod/data/tests/generator_test.php:221
      		 
      /home/jake/moodledata/omaster/moodle/lib/phpunit/classes/advanced_testcase.php:80
      		 
       
      		 
      To re-run:
      		 
       vendor/bin/phpunit mod_data_generator_testcase mod/data/tests/generator_test.php
      		 
       
      		 
      FAILURES!
      		 
      Tests: 3, Assertions: 70, Failures: 1.

      The first run passed, but subsequent runs hit this error every time. The problem is that the default sort by (which should be ASC), isn't functioning properly.

      Attachments

        Issue Links

          Discovered while testing

          Task - A task that needs to be completed. Tasks usually refer to work that must be done outside the product. MDL-55999 Upgrade ADOdb to 5.20.7 for Moodle 3.2 release

          • Minor - Minor loss of function where workaround is possible
          • Closed
          is a regression caused by

          Sub-task - Issues are sometimes broken into multiple sub-tasks. MDL-55127 Add database entries to global search

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Activity

            People

              jaked Jake Dallimore
              jaked Jake Dallimore
              Rajesh Taneja Rajesh Taneja
              Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
              Simey Lameze Simey Lameze
              Amaia Anabitarte, Carlos Escobedo, Laurent David, Sabina Abellan, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                5/Dec/16