Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-56240

Incorrect v3.2.0 release upgrade line's being introduced into the codebase

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 3.2
    • 3.2.1
    • Libraries
    • MOODLE_32_STABLE
    • MOODLE_32_STABLE
    • Hide

      Verify that there aren't occurrences of // Moodle v3.2.0 in codebase.

      Any of these should be enough:

      • grep -r '\/\/ Moodle v3.2.0'
      • ag '\/\/ Moodle v3.2.0'
      Show
      Verify that there aren't occurrences of // Moodle v3.2.0 in codebase. Any of these should be enough: grep -r '\/\/ Moodle v3.2.0' ag '\/\/ Moodle v3.2.0'

    Description

      I've seen this in a number of patches at in the last few months, people seem to be getting the wrong impression about these lines. It seems some have already slipped in:

       git grep 'v3.2.0 release upgrade'
      		 
      enrol/self/db/upgrade.php:    // Moodle v3.2.0 release upgrade line.
      		 
      mod/lti/db/upgrade.php:    // Moodle v3.2.0 release upgrade line.

      These lines are introduced by the release process and they added just before the release happens, so say 'this is where v3.2.0 was released'.

      Attachments

        Issue Links

          blocks

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-57266 Add Moodle 3.2.0 upgrade line to all the upgrade.php scripts

          • Minor - Minor loss of function where workaround is possible
          • Closed
          has a non-specific relationship to

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-54677 Add Moodle 3.1.0 upgrade line to all the upgrade.php scripts

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Activity

            People

              stronk7 Eloy Lafuente (stronk7)
              poltawski Dan Poltawski
              Dan Poltawski Dan Poltawski
              Andrew Lyons Andrew Lyons
              Frédéric Massart Frédéric Massart
              David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                9/Jan/17