Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-56240

Incorrect v3.2.0 release upgrade line's being introduced into the codebase

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • 3.2.1
    • 3.2
    • Libraries
    • MOODLE_32_STABLE
    • MOODLE_32_STABLE
    • Hide

      Verify that there aren't occurrences of // Moodle v3.2.0 in codebase.

      Any of these should be enough:

      • grep -r '\/\/ Moodle v3.2.0'
      • ag '\/\/ Moodle v3.2.0'
      Show
      Verify that there aren't occurrences of // Moodle v3.2.0 in codebase. Any of these should be enough: grep -r '\/\/ Moodle v3.2.0' ag '\/\/ Moodle v3.2.0'

      I've seen this in a number of patches at in the last few months, people seem to be getting the wrong impression about these lines. It seems some have already slipped in:

       git grep 'v3.2.0 release upgrade'
      		 
      enrol/self/db/upgrade.php:    // Moodle v3.2.0 release upgrade line.
      		 
      mod/lti/db/upgrade.php:    // Moodle v3.2.0 release upgrade line.

      These lines are introduced by the release process and they added just before the release happens, so say 'this is where v3.2.0 was released'.

            stronk7 Eloy Lafuente (stronk7)
            poltawski Dan Poltawski
            Dan Poltawski Dan Poltawski
            Andrew Lyons Andrew Lyons
            Frédéric Massart Frédéric Massart
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.