[MDL-56250] Moodle form validation caches results for all objects. - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.0.4, 3.1, 3.2
Fix Version/s: 3.0.7, 3.1.3
Component/s: Forms Library
Labels:
- ci

Testing Instructions:

Hide

Please check the phpunit test added to the proposed solution.
Verify there isn't phpunit/behat regressions.

Show
Please check the phpunit test added to the proposed solution. Verify there isn't phpunit/behat regressions.
Workaround:

Hide

You can extend the class and reimplement the validate_defined_fields() if needed.

Show
You can extend the class and reimplement the validate_defined_fields() if needed.
Difficulty:
Easy
Affected Branches:
MOODLE_30_STABLE, MOODLE_31_STABLE, MOODLE_32_STABLE
Fixed Branches:
MOODLE_30_STABLE, MOODLE_31_STABLE
Pull from Repository:
https://github.com/roperto/moodle
Pull Master Branch:
~~MDL-56250~~-32-formvalidation
Pull Master Diff URL:
https://github.com/moodle/moodle/compare/919b9dfabd69f71c088f565746c547e6e169a0b7...roperto:MDL-56250-32-formvalidation

Description

In validate_defined_fields() it uses

static $validated = null; // one validation is enough

However, we can have more than one form being validated, I believe this $validated should me an instance variable, not static.

Please see my solution for a phpunit test showing the problem.

Attachments

Activity

People

Assignee:: Daniel Thee Roperto

Reporter:: Daniel Thee Roperto

Peer reviewer:: Adrian Greeve

Integrator:: Eloy Lafuente (stronk7)

Tester:: CiBoT

Participants:: Adrian Greeve, CiBoT, Daniel Thee Roperto, Dan Poltawski, Eloy Lafuente (stronk7), Marina Glancy, Rajesh Taneja

Component watchers:: Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias

Votes:: 0 Vote for this issue

Watchers:: 3 Start watching this issue

Dates

Created:: 04/Oct/16 5:45 PM

Updated:: 28/Oct/16 5:16 AM

Resolved:: 28/Oct/16 5:16 AM

Fix Release Date:: 14/Nov/16