[MDL-56250] Moodle form validation caches results for all objects. - Moodle Tracker

XML

Word

Printable

Testing Instructions:

Hide

Please check the phpunit test added to the proposed solution.
Verify there isn't phpunit/behat regressions.

Show
Please check the phpunit test added to the proposed solution. Verify there isn't phpunit/behat regressions.
Workaround:

Hide

You can extend the class and reimplement the validate_defined_fields() if needed.

Show
You can extend the class and reimplement the validate_defined_fields() if needed.
Difficulty:
Easy
Affected Branches:
MOODLE_30_STABLE, MOODLE_31_STABLE, MOODLE_32_STABLE
Fixed Branches:
MOODLE_30_STABLE, MOODLE_31_STABLE
Pull from Repository:
https://github.com/roperto/moodle
Pull Master Branch:
~~MDL-56250~~-32-formvalidation
Pull Master Diff URL:
https://github.com/moodle/moodle/compare/919b9dfabd69f71c088f565746c547e6e169a0b7...roperto:MDL-56250-32-formvalidation

In validate_defined_fields() it uses

static $validated = null; // one validation is enough

However, we can have more than one form being validated, I believe this $validated should me an instance variable, not static.

Please see my solution for a phpunit test showing the problem.