Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-56324

EditPDF: next/previous page buttons navigate to wrong page after jumping to comment

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0.6, 3.1.2, 3.2.1
    • Fix Version/s: 3.2.3
    • Component/s: Assignment
    • Labels:
    • Testing Instructions:
      Hide
      1. Create an assignment activity with file upload submissions enabled.
      2. As a student, submit a PDF with at least 4 pages.
      3. As a teacher, grade the submission and add comments to pages 1 and 2.
      4. Using the 'Search comments' tool, jump to a comment on page 2.
      5. Check that the selected comment has focus.
      6. Using the 'Next page' button, navigate to page 3. This should require just a single click.
      7. Using the 'Search comments' tool, jump to a comment on page 1.
      8. Check that the selected comment has focus.
      9. Using the 'Next page' button, navigate to the next page.
      10. Check that you are now on page 2.
      11. Using the 'Search comments' tool, jump to a comment on page 2.
      12. Check that the selected comment has focus.
      13. Using the 'Previous page' button, navigate to the previous page.
      14. Check that you are now on page 1.
      15. Using the 'Search comments' tool, select a comment on page 2.
      16. Check that you are now on page 2, and that the selected comment has focus.
      17. Add at least one comment to the quicklist, then reload the page.
      18. Make sure you are now on page 1.
      19. Using the 'Search comments' tool, jump to a comment on page 2.
      20. Check that the selected comment has focus.
      21. Using the quicklist menu for the comment you just jumped to, select a saved quicklist comment.
      22. Check that you are still on page 2, that this is reported correctly in the page selector, and that the comment has updated correctly.
      Show
      Create an assignment activity with file upload submissions enabled. As a student, submit a PDF with at least 4 pages. As a teacher, grade the submission and add comments to pages 1 and 2. Using the 'Search comments' tool, jump to a comment on page 2. Check that the selected comment has focus. Using the 'Next page' button, navigate to page 3. This should require just a single click. Using the 'Search comments' tool, jump to a comment on page 1. Check that the selected comment has focus. Using the 'Next page' button, navigate to the next page. Check that you are now on page 2. Using the 'Search comments' tool, jump to a comment on page 2. Check that the selected comment has focus. Using the 'Previous page' button, navigate to the previous page. Check that you are now on page 1. Using the 'Search comments' tool, select a comment on page 2. Check that you are now on page 2, and that the selected comment has focus. Add at least one comment to the quicklist, then reload the page. Make sure you are now on page 1. Using the 'Search comments' tool, jump to a comment on page 2. Check that the selected comment has focus. Using the quicklist menu for the comment you just jumped to, select a saved quicklist comment. Check that you are still on page 2, that this is reported correctly in the page selector, and that the comment has updated correctly.
    • Affected Branches:
      MOODLE_30_STABLE, MOODLE_31_STABLE, MOODLE_32_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-56324-master

      Description

      To reproduce:

      1. Create an assignment activity with file upload submissions enabled.
      2. As a student, submit a PDF with at least 4 pages.
      3. As a teacher, grade the submission and add comments to pages 1 and 2.
      4. Using the 'Search comments' tool, jump to a comment on page 2.
      5. Using the 'Next page' button, navigate to page 3. This will require 2 clicks because the navigation is not aware that we have moved away from page 1.
      6. Using the 'Search comments' tool, jump to a comment on page 1.
      7. Using the 'Next page' button, navigate to the next page (should be page 2, actually page 4 because the navigation still 'thinks' we are on page 3).
      8. Using the 'Search comments' tool, jump to a comment on page 2.
      9. Using the 'Previous page' button, navigate to the previous page (should be page 1, actually page 3).
        The converse problem also exists, so following on from the above steps:
      10. Using the 'Previous page' button again, navigate back to page 1. This should now work correctly in 2 clicks because we used the page navigation last. However ...
      11. Using the 'Search comments' tool, select a comment on page 2. This will now fail because the tool isn't aware that we have navigated away from page 2, therefore change_page() isn't called and the comment node can't be found (as indicated in the console log).

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                8 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  8/May/17