Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-56331

core_iplookup_geoip_testcase is failing

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 3.2
    • 3.2
    • Unit tests

    Description

      I am seeing following failure:

      There was 1 failure:
       
      1) core_iplookup_geoip_testcase::test_ipv4
      Failed asserting that 0.1167 matches expected 0.1249.
       
      /home/rajesh/moodles/m/moodle/iplookup/tests/geoip_test.php:89
      /home/rajesh/moodles/m/moodle/lib/phpunit/classes/advanced_testcase.php:80
      

      Looking at the results on https://www.iplocation.net/ for "131.111.150.25", it shows longitude is 0.1167, but with different sites, the data is different.

      Just wondering if this test should be removed or validated in different way.

      Adding poltawski for his thoughts.

      Attachments

        Issue Links

          Activity

            People

              poltawski Dan Poltawski
              rajeshtaneja Rajesh Taneja
              Rajesh Taneja Rajesh Taneja
              Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
              CiBoT CiBoT
              Andrew Lyons, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Stevani Andolo
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                5/Dec/16