Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-56341

Mustache: Quote and Str helpers do not work together in JS

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0.6, 3.1.2, 3.2
    • Fix Version/s: 3.0.7, 3.1.3
    • Component/s: Themes
    • Labels:
    • Testing Instructions:
      Hide
      1. Download the two attached files
        • test_mustache.php to your dirroot
        • test.mustache to lib/templates
      2. Access /test_mustache.php
      3. Confirm that you don't see any gibberish as see in the description of this issue
      4. Click the button to load the same template via JS
      5. Confirm that there is no gibberish and that both samples look identical
      Show
      Download the two attached files test_mustache.php to your dirroot test.mustache to lib/templates Access /test_mustache.php Confirm that you don't see any gibberish as see in the description of this issue Click the button to load the same template via JS Confirm that there is no gibberish and that both samples look identical
    • Affected Branches:
      MOODLE_30_STABLE, MOODLE_31_STABLE, MOODLE_32_STABLE
    • Fixed Branches:
      MOODLE_30_STABLE, MOODLE_31_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-56341-master

      Description

      During MDL-56162 integration testing I've noticed that uniqid was available when using clean theme but not when using boost theme.

      Steps to reproduce:

      1. Download https://tracker.moodle.org/secure/attachment/51087/test_modal.php and move it to your dirroot
      2. Open it using theme_boost and open a modal
      3. Inspect the modal's close button
      4. You will see something like =<% %>=<%={{ }}=%>_s2{{=<% %>=}}<%={{ }}=%>, which seems unexpected
      5. Repeat using theme_clean
      6. uniqid is just an int, which seems expected

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              fred Frédéric Massart
              Reporter:
              dmonllao David Monllaó
              Peer reviewer:
              Damyon Wiese
              Integrator:
              Andrew Nicols
              Tester:
              Adrian Greeve
              Participants:
              Component watchers:
              Bas Brands
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                14/Nov/16