Loading...

XML

Word

Printable

Affected Branches:
MOODLE_30_STABLE, MOODLE_31_STABLE, MOODLE_32_STABLE
Fixed Branches:
MOODLE_30_STABLE, MOODLE_31_STABLE
Epic Link:
Theme and Nav changes for 3.2
Pull from Repository:
git://github.com/damyon/moodle.git
Pull Main Branch:
~~MDL-56341~~-master
Pull Main Diff URL:
https://github.com/damyon/moodle/compare/d9520bc04e...MDL-56341-master
Testing Instructions:
Hide

Download the two attached files

test_mustache.php to your dirroot

test.mustache to lib/templates

Access /test_mustache.php

Confirm that you don't see any gibberish as see in the description of this issue

Click the button to load the same template via JS

Confirm that there is no gibberish and that both samples look identical
Show
Download the two attached files test_mustache.php to your dirroot test.mustache to lib/templates Access /test_mustache.php Confirm that you don't see any gibberish as see in the description of this issue Click the button to load the same template via JS Confirm that there is no gibberish and that both samples look identical

During ~~MDL-56162~~ integration testing I've noticed that uniqid was available when using clean theme but not when using boost theme.

Steps to reproduce:

Download https://tracker.moodle.org/secure/attachment/51087/test_modal.php and move it to your dirroot
Open it using theme_boost and open a modal
Inspect the modal's close button
You will see something like =<% %>=<%={{ }}=%>_s2{{=<% %>=}}<%={{ }}=%>, which seems unexpected
Repeat using theme_clean
uniqid is just an int, which seems expected

Discovered while testing

MDL-56162 New modals do not work in Boost

is duplicated by

MDL-56054 Mustache quotes helper does not work the same as php version

Participants:: Adrian Greeve, Andrew Lyons, CiBoT, Damyon Wiese, Dan Poltawski, David Monllaó, Eloy Lafuente (stronk7), Frédéric Massart