Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-56389

Mark all as read is too greedy

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Waiting for peer review
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: 3.2, 3.7
    • Fix Version/s: None
    • Component/s: Messages
    • Labels:
    • Testing Instructions:
      Hide

      Test requires two different browser windows open (i.e. Firefox & Chrome), as it requires switching between them throughout

      Browser 1 (Administrator)

      1. Login as Administrator
      2. Create a new course named Test messaging
      3. Create two users: John Smith & Joe Tester
      4. Enrol both users in new course
      5. Log out

      Browser 1 (John Smith)

      1. Login as John Smith
      2. Visit Test messaging course
      3. Press Participants
      4. Click on profile for Joe Tester
      5. Press Add to contacts
      6. Logout

      Browser 2 (Joe Tester)

      1. Login as Joe Tester
      2. Toggle the notifications menu open
      3. Observe you have an unread Contact request from John Smith notification

      Browser 1 (Administrator)

      1. Login as Administrator
      2. Visit Test messaging course
      3. Press Participants
      4. Click on profile for Joe Tester
      5. Press Add to contacts
      6. Logout

      Browser 2 (Joe Tester)

      1. Press the Mark all as read button
      2. Toggle the notification menu closed
      3. Reload the page
      4. Toggle the notification menu open
      5. Observe you have an unread Contact request from Administrator notification
      6. Observe you have a read Contact request from John Smith notification
      7. Press the Mark all as read button
      8. Toggle the notification menu closed
      9. Reload the page
      10. Toggle the notification menu open
      11. Observe that both notifications from step 5 & 6 are now read
      Show
      Test requires two different browser windows open (i.e. Firefox & Chrome), as it requires switching between them throughout Browser 1 (Administrator) Login as Administrator Create a new course named Test messaging Create two users: John Smith & Joe Tester Enrol both users in new course Log out Browser 1 (John Smith) Login as John Smith Visit Test messaging course Press Participants Click on profile for Joe Tester Press Add to contacts Logout Browser 2 (Joe Tester) Login as Joe Tester Toggle the notifications menu open Observe you have an unread Contact request from John Smith notification Browser 1 (Administrator) Login as Administrator Visit Test messaging course Press Participants Click on profile for Joe Tester Press Add to contacts Logout Browser 2 (Joe Tester) Press the Mark all as read button Toggle the notification menu closed Reload the page Toggle the notification menu open Observe you have an unread Contact request from Administrator notification Observe you have a read Contact request from John Smith notification Press the Mark all as read button Toggle the notification menu closed Reload the page Toggle the notification menu open Observe that both notifications from step 5 & 6 are now read
    • Affected Branches:
      MOODLE_32_STABLE, MOODLE_37_STABLE
    • Pull Master Branch:

      Description

      If a user messages me
      And I open the Messages popover
      And the user then sends me another message
      And I then click the "Mark all as read" button
      Then all of their messages are marked as read, and not just the ones I have seen

        Attachments

          Activity

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 20 minutes
                20m