Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-56393

Unread notifications/messages in popover indented on course view page

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 3.2
    • Fix Version/s: 3.2
    • Component/s: Messages
    • Labels:
    • Testing Instructions:
      Hide

      Note you'll need to test on both "clean" and "boost" themes

      1. Log in as admin
      2. Create a course
      3. Create an assignment and set it to online text
      4. Enrol a user
      5. Log in as the enrolled user
      6. Open your notification preferences and enable Online Web notifications for Assignment notifications
      7. Submit something to the assignment (this should generate an unread notification for you)
      8. Navigate to the course page to view the course
      9. Open the notification popover (in the nav bar) and confirm that the unread notification isn't indented (i.e. it has no margin).
      10. Change the language to and RTL language and confirm that the unread notification still isn't indented
      Show
      Note you'll need to test on both "clean" and "boost" themes Log in as admin Create a course Create an assignment and set it to online text Enrol a user Log in as the enrolled user Open your notification preferences and enable Online Web notifications for Assignment notifications Submit something to the assignment (this should generate an unread notification for you) Navigate to the course page to view the course Open the notification popover (in the nav bar) and confirm that the unread notification isn't indented (i.e. it has no margin). Change the language to and RTL language and confirm that the unread notification still isn't indented
    • Affected Branches:
      MOODLE_32_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE
    • Pull Master Branch:
      MDL-56393-master

      Description

      Steps to replicate:

      1. Generate some unread notifications / messages
      2. View a course
      3. Open popover

      This is because the margin from the .path-course-view .unread rule is applying to the .content-item-container.unread items.

      Just need to add a "margin-left: 0" to the .content-item-container.unread CSS rule to negate it.

      See:

        Attachments

          Activity

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                5/Dec/16