Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-56409

If notifications are disabled then no need to check unread notifications for every request

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Blocker
    • Resolution: Fixed
    • 3.2
    • 3.2
    • Messages
    • MOODLE_32_STABLE
    • MOODLE_32_STABLE
    • MDL-56409-master
    • Hide
      1. Do regression testing with messages and notifications.
      2. Disable notification and test for regressions.

      Test 2

      1. Deploy a way to log DB queries based on your db.
      2. Disable notifications
      3. Load the home page multiple times
      4. Make sure this giant query is not executed - https://github.com/ankitagarwal/moodle/compare/7eb3467...MDL-56409-master#diff-074a274a0b608f2f52d21d337a936c5cR76

      Test 3

      1. Disable the message popover processor
      2. Reload the home page multiple times
      3. Make sure there is no db call to get the processor on every request
      Show
      Do regression testing with messages and notifications. Disable notification and test for regressions. Test 2 Deploy a way to log DB queries based on your db. Disable notifications Load the home page multiple times Make sure this giant query is not executed - https://github.com/ankitagarwal/moodle/compare/7eb3467...MDL-56409-master#diff-074a274a0b608f2f52d21d337a936c5cR76 Test 3 Disable the message popover processor Reload the home page multiple times Make sure there is no db call to get the processor on every request

    Description

      Currently unread notifications are being read from db for each request. When notifications are disabled on server or user has disabled notifications, then it will be nice to just cache this information and don't do redundant dbquery as that is not required.

      Attachments

        Issue Links

          Testing discovered

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-56871 The messaging UI shows the 'online' status inconsistently

          • Critical - Crashes server, loss of data, severe memory leak
          • Closed

          Activity

            People

              ankit_frenz Ankit Agarwal
              rajeshtaneja Rajesh Taneja
              Simey Lameze Simey Lameze
              David Monllaó David Monllaó
              Rajesh Taneja Rajesh Taneja
              Votes:
              1 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                5/Dec/16