Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-56436

Update mustache.php readme to indicate its no longer custom

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.1.2, 3.2
    • Fix Version/s: 3.2
    • Component/s: HTML and CSS
    • Labels:

      Description

      lib/mustache/readme_moodle.txt says:

      Clone from https://github.com/moodle/custom-mustache.php
      Rebase onto latest tag from https://github.com/bobthecow/mustache.php

      Yet, on 3.1, if I do..

      wget https://github.com/bobthecow/mustache.php/archive/v2.10.0.tar.gz
      tar -xzvf v2.10.0.tar.gz
      rm -R lib/mustache/src/
      $  mv mustache.php-2.10.0/src/ lib/mustache/
      

      There are no differences. (Same applies to 3.2 and v2.11.1).

      So either:

      • We are missing some commits (and have a broken functionality for multiple releases)
      • The readme_moodle.txt is outdated and needs to be fixed

      The status of https://github.com/moodle/custom-mustache.php is really unclear. Which branch do you rebase and so on?

      This needs sorting out

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              poltawski Dan Poltawski
              Reporter:
              poltawski Dan Poltawski
              Integrator:
              Eloy Lafuente (stronk7)
              Tester:
              Eloy Lafuente (stronk7)
              Participants:
              Component watchers:
              Amy Groshek, David Scotson, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                5/Dec/16