Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-56437

Unoconv processing appears to ignore failures

    XMLWordPrintable

    Details

      Description

      The get_converted_document() function in lib/filestorage/file_storage.php is capable of returning false if the function that does the work - create_converted_document() - indicates a failure. The latter actually makes a useful check that unconv has generated a new file in the temporary area and returns false if none is found. Unoconv is far from 100% reliable, we see quite a few 'Office probably died' errors and no conversion is produced, so this is a real problem.

      Unfortunately, when this is called in Assignment the return value is mostly ignored. If false is returned the calling code just drops through. This, presumably, is what results in spinning wheels followed by a blank page in the grading screen rather than a useful error message.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                29 Vote for this issue
                Watchers:
                36 Start watching this issue

                Dates

                • Created:
                  Updated: