Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-56459

PHP5 - PHP7 differences in exporter

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.1, 3.1.3, 3.2
    • Fix Version/s: 3.1.4, 3.2.1
    • Component/s: Competencies
    • Labels:

      Description

      While reviewing MDL-56430 I've remembered what we worked on as part of the PHP7 compatibility push (http://php.net/manual/en/migration70.incompatible.php#migration70.incompatible.variable-handling.indirect) and I ran

      git grep "[a-zA-Z_]*->\$[a-zA-Z_]*\["
      

      Which highlighted the case below

      competency/classes/external/exporter.php:            $data->$property[$key] = external_format_string($value, $context->id);
      

      I haven't tested it, but it seems that it would fall under $foo->$bar['baz']

        Attachments

          Activity

            People

            Assignee:
            fred Frédéric Massart
            Reporter:
            dmonllao David Monllaó
            Peer reviewer:
            Ankit Agarwal
            Integrator:
            Dan Poltawski
            Tester:
            CiBoT
            Participants:
            Component watchers:
            Damyon Wiese, Jean-Philippe Gaudreau, Steve Massicotte, Serge Gauthier, Issam Taboubi, Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              9/Jan/17