Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-56469

Boost Themes - section activity indent too wide when not editing

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. With Boost theme selected choose a course that has an activity listed in a section.
      2. Make sure that the Course Format is Topics or Weeks, if not change it.
      3. With Editing ON check to see that the left hand indent allows for the 'move' icon to be visible and not over shadowed by the Activity icon.
      4. Turn Editing OFF and check to see that the Activity icon is no longer indented and back to its normal position, which is no padding-left.
      1. Check 1 to 4 as above but for the right hand move icon when in RTL language.
      Show
      With Boost theme selected choose a course that has an activity listed in a section. Make sure that the Course Format is Topics or Weeks, if not change it. With Editing ON check to see that the left hand indent allows for the 'move' icon to be visible and not over shadowed by the Activity icon. Turn Editing OFF and check to see that the Activity icon is no longer indented and back to its normal position, which is no padding-left. Check 1 to 4 as above but for the right hand move icon when in RTL language.
    • Affected Branches:
      MOODLE_32_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE
    • Epic Link:
    • Pull from Repository:
    • Pull Master Branch:
      MDL-56469-M32
    • Pull Master Diff URL:

      Description

      MDL-56328 continuation, feel free to ignore if you think we shouldn't fix this in boost.

      To resume .mod-indent-outer with editing mode off don't need a 32px padding, in MDL-56328 the padding was moved to editing mode on, so the move activity icon is not overlapped (that was the original purpose of that padding for what I understand) Not sure if the same solution using px would be the best option in boost case.

      Marking it as a bug because MDL-56328 is marked as a bug, I would say this is an improvement.

        Attachments

          Issue Links

          has a non-specific relationship to

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-56328 Bootstrapbase Themes - section activity indent too wide when not editing

          • Minor - Minor loss of function where workaround is possible
          • Closed

            Activity

              People

              Assignee:
              lazydaisy Mary Evans
              Reporter:
              dmonllao David Monllaó
              Peer reviewer:
              John Okely
              Integrator:
              Andrew Nicols
              Tester:
              Simey Lameze
              Participants:
              Component watchers:
              Bas Brands
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                5/Dec/16