[MDL-56514] Missing $CFG->messaging check in WS functions - Moodle Tracker

XML

Word

Printable

Testing Instructions:
Hide

WS testing

Log in as admin and disable messaging $CFG->messaging

Test the following WS functions:

get_unread_conversations_count

get_blocked_users

mark_all_messages_as_read

message_processor_config_form

Make sure it throws an exception of messaging is disabled in all functions.

Now, enable that setting again.

Repeat the test and make sure it does not throw exceptions.

Do a exploratory test, with messaging enabled and disabled, make sure it does not throw unexpected exceptions.
Show
WS testing Log in as admin and disable messaging $CFG->messaging Test the following WS functions: get_unread_conversations_count get_blocked_users mark_all_messages_as_read message_processor_config_form Make sure it throws an exception of messaging is disabled in all functions. Now, enable that setting again. Repeat the test and make sure it does not throw exceptions. Do a exploratory test, with messaging enabled and disabled, make sure it does not throw unexpected exceptions.
Affected Branches:
MOODLE_32_STABLE
Fixed Branches:
MOODLE_32_STABLE
Epic Link:
Messaging issues
Pull from Repository:
git://github.com/lameze/moodle.git
Pull Master Branch:
~~MDL-56514~~-master
Pull Master Diff URL:
https://github.com/lameze/moodle/compare/0b03040...MDL-56514-master

Some of the new WS functions introduced in ~~MDL-54682~~ are missing the $CFG->messaging check.

Participants:: Adrian Greeve, Ankit Agarwal, CiBoT, Dan Poltawski, Eloy Lafuente (stronk7), Mark Nelson, Simey Lameze

Component watchers:: Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)