Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-56514

Missing $CFG->messaging check in WS functions

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 3.2
    • Fix Version/s: 3.2
    • Component/s: Messages
    • Labels:
    • Testing Instructions:
      Hide
      WS testing
      1. Log in as admin and disable messaging $CFG->messaging
      2. Test the following WS functions:
        • get_unread_conversations_count
        • get_blocked_users
        • mark_all_messages_as_read
        • message_processor_config_form
      3. Make sure it throws an exception of messaging is disabled in all functions.
      4. Now, enable that setting again.
      5. Repeat the test and make sure it does not throw exceptions.
      6. Do a exploratory test, with messaging enabled and disabled, make sure it does not throw unexpected exceptions.
      Show
      WS testing Log in as admin and disable messaging $CFG->messaging Test the following WS functions: get_unread_conversations_count get_blocked_users mark_all_messages_as_read message_processor_config_form Make sure it throws an exception of messaging is disabled in all functions. Now, enable that setting again. Repeat the test and make sure it does not throw exceptions. Do a exploratory test, with messaging enabled and disabled, make sure it does not throw unexpected exceptions.
    • Affected Branches:
      MOODLE_32_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-56514-master

      Description

      Some of the new WS functions introduced in MDL-54682 are missing the $CFG->messaging check.

        Attachments

          Activity

            People

            Assignee:
            lameze Simey Lameze
            Reporter:
            markn Mark Nelson
            Peer reviewer:
            Adrian Greeve
            Integrator:
            Dan Poltawski
            Tester:
            Ankit Agarwal
            Participants:
            Component watchers:
            Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              5/Dec/16