Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-56519

Lint .feature files

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      Test 1: Test no lint errors exist.
      1. npm install
      2. grunt gherkinlint
      3. Ensure you don't see any behat lint errors.
      Test 2: Sanity check.
      1. Go though the patch and ensure changes are not modifying scenario steps. Only:
        • Indentation
        • Feature name/description
      Test 3: Test gherkinlint is executed during watch
      1. Execute grunt watch
      2. Modify some feature file and save
      3. Check the modifications in feature file are reported by grunt watch
      Test 4: Test gherkinlint is executed by grunt
      1. Execute grunt
      2. Check gherkinlint task is executed.
      Show
      Test 1: Test no lint errors exist. npm install grunt gherkinlint Ensure you don't see any behat lint errors. Test 2: Sanity check. Go though the patch and ensure changes are not modifying scenario steps. Only: Indentation Feature name/description Test 3: Test gherkinlint is executed during watch Execute grunt watch Modify some feature file and save Check the modifications in feature file are reported by grunt watch Test 4: Test gherkinlint is executed by grunt Execute grunt Check gherkinlint task is executed.
    • Affected Branches:
      MOODLE_32_STABLE, MOODLE_33_STABLE
    • Fixed Branches:
      MOODLE_33_STABLE
    • Pull Master Branch:
      wip-mdl-56519-m

      Description

      Did you know we have more .feature files than .css in Moodle?

      Perhaps we should lint them

      https://github.com/vsiakka/gherkin-lint

      I've created a quick grunt task.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              rajeshtaneja Rajesh Taneja
              Reporter:
              poltawski Dan Poltawski
              Peer reviewer:
              Dan Poltawski
              Integrator:
              Eloy Lafuente (stronk7)
              Tester:
              Jun Pataleta
              Participants:
              Component watchers:
              Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                15/May/17