Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-56523

Theme Boost: some mustache templates do not need region-main-box

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.2
    • Fix Version/s: 3.2
    • Component/s: Themes
    • Labels:

      Description

      I think I queried this in another tracker a few weeks ago. However I thought it should be brought up as a query in its own tracker, so here goes...

      The use of region-main-box was used in Bootstrapbase for a three column layout only. However now that we are only using a two column default layout we can dispense with the region-main-box container, thus cutting back on unnecessary padding/negative margins and the extra row container.

      With these changes in place the page section of the columns2.mustache would then look like this:

          <div id="page" class="container">
              {{{ output.full_header }}}
       
              <div id="page-content" class="row">
                  <section id="region-main" class="col-md-8 push-md-4">
                      {{{ output.course_content_header }}}
                      {{{ output.main_content }}}
                      {{{ output.course_content_footer }}}
                   </section>
              </div>
       
              {{{ sidepreblocks }}}
          </div>
      

      Other related layouts include maintenance.mustache and columns1.mustache.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  5/Dec/16