Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-56581

Add a override permission class in roles/override.php to allow colour highlighting of overridden permission rows

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.1.2
    • Fix Version/s: 3.3
    • Component/s: Roles / Access
    • Labels:
    • Testing Instructions:
      Hide

      Should be tested in boost, clean and more

      1. As admin in a course navigate to Administration/Course administration/Users/Permissions
      2. Choose a role to override from the Advanced role override select drop-down
      3. Click a radio button (other than Inherit) for at least one capability
      4. Press the 'Save changes' button
      5. Again choose the same role from the Advanced role override select drop-down
      6. You should now see a background highlighted colour for the selected capability or capabilities you changed from 'Inherit'

      Show
      Should be tested in boost, clean and more 1. As admin in a course navigate to Administration/Course administration/Users/Permissions 2. Choose a role to override from the Advanced role override select drop-down 3. Click a radio button (other than Inherit) for at least one capability 4. Press the 'Save changes' button 5. Again choose the same role from the Advanced role override select drop-down 6. You should now see a background highlighted colour for the selected capability or capabilities you changed from 'Inherit'
    • Affected Branches:
      MOODLE_31_STABLE
    • Fixed Branches:
      MOODLE_33_STABLE
    • Pull Master Branch:
      wip-MDL-56581-master

      Description

      Currently the admin/roles/override.php page does not allow for coloured highlighting of permissions which have been overriden.
      We have been asked if this is possible by our administration team so that permissions which have been overridden can be more easily identified.

      Adding a simple new get_row_attributes function to the core_role_override_permissions_table_advanced subclass with a corresponding addition in the css would allow for this.

      Navigate to /admin/roles/permissions.php via a course administration block selecting 'Users' 'Permissions' then selecting a role from the 'Advanced role override' dropdown.
      If you select a radio button option for a capability other than the one inherited it currently does not give you any highlighted indication that this is not the inherited option.
      It would make for easier comprehension of the current status of the role easier if coloured highlighting was shown in the background for non-inherited capabilities.

        Gliffy Diagrams

          Attachments

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  15/May/17