Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-56592

User report and Grader report are inconsistent for the grade that is hidden. Allow teacher to toggle to/from "user view" (Backport of MDL-30179)

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Run behat tests (@gradereport_user)

      1. Create a course, enroll student and a teacher
      2. In that course, create several grade items and categories, hide various ones. We want at least one hidden category, and one hidden item in a visible category.
      3. Give the student a grade in each grade item
      4. In two separate browsers, login as the student and the teacher
      5. As the teacher go to the Course grade settings
      6. Make sure Hide totals if they contain hidden items under User report (very bottom) is set to Hide
      7. Navigate to the user grade report for the course in both courses
      8. In the teacher browser, set the report user to the student
      9. Set View report as to Myself
      10. Confirm all items and totals are visible
      11. Set View report as to User
      12. Compare the student and teacher windows of the user report
      13. Confirm that the same items are visible and not visible between the two, and that the same totals are shown.
      14. Repeat steps 4-13, but with the settings Show totals including hidden and Show totals excluding hidden

      Student permission

      1. Login as an admin
      2. Change the student role to allow the moodle/grade:viewhidden permission
      3. Repeat steps 4-14 of the section above

      Confirm sticky setting

      1. Login as a teacher
      2. Go to a course, then to the user report
      3. Set View user as to Myself
      4. Log out
      5. Log back in as the teacher
      6. Go to a course, then to the user report
      7. Confirm View user as is set to Myself
      Show
      Run behat tests (@gradereport_user) Create a course, enroll student and a teacher In that course, create several grade items and categories, hide various ones. We want at least one hidden category, and one hidden item in a visible category. Give the student a grade in each grade item In two separate browsers, login as the student and the teacher As the teacher go to the Course grade settings Make sure Hide totals if they contain hidden items under User report (very bottom) is set to Hide Navigate to the user grade report for the course in both courses In the teacher browser, set the report user to the student Set View report as to Myself Confirm all items and totals are visible Set View report as to User Compare the student and teacher windows of the user report Confirm that the same items are visible and not visible between the two, and that the same totals are shown. Repeat steps 4-13, but with the settings Show totals including hidden and Show totals excluding hidden Student permission Login as an admin Change the student role to allow the moodle/grade:viewhidden permission Repeat steps 4-14 of the section above Confirm sticky setting Login as a teacher Go to a course, then to the user report Set View user as to Myself Log out Log back in as the teacher Go to a course, then to the user report Confirm View user as is set to Myself
    • Affected Branches:
      MOODLE_31_STABLE
    • Fixed Branches:
      MOODLE_31_STABLE
    • Pull 3.1 Branch:

      Description

      This is a backport request of MDL-30179.

      Background

      Prior to MDL-30179 landing in 3.2, there was actually no way for an instructor to see grades the same as the student does, they would always see them with their own permissions. This is a bit problem with hidden items, and various settings of Show aggregates including/excluding/etc hidden items.

      This leads to confusion where the teacher and student see different final grades in the course.

      MDL-30179 added a new, sticky (remembers users last setting) toggle to switch the User grade report between viewing it with the other users permissions, or their own.

      Backport rational

      • The issue has been very long standing, with many (closed) duplicates.
      • The issue causes many support calls, and complicated explanations.
      • Many thought the problem was to be fixed in the 2.8 gradebook work, but it was not.
      • 3.1 is a LTS, so backporting this will have longer than usual impact.
      • The change is relatively small:
        • The backing logic for the display was developed quite some time ago for use with "Parent" views.
        • The UI change is the addition of a simple single select under the existing single select for User.
      • Doesn't (directly) impact students/parents - only those with the moodle/grade:viewall permission (normally teachers and above).
      • The old behavior is still retained/available for those affected.
      • Includes behat testing of new and old behavior.

      If this gets approved for backporting, I will post branches and test instructions

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                1 Vote for this issue
                Watchers:
                7 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  13/Mar/17