Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-56615

Error while adding portfolio on php 7.0.9

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.1.2, 3.2
    • Fix Version/s: 3.0.7, 3.1.3
    • Component/s: Portfolio
    • Labels:
    • Environment:
      # php 7.0.9 and probably below.
      # ubuntu
    • Testing Instructions:
      Hide

      On php 7.0.9

      1. Enable portfolio
      2. go to manage portfolio
      3. enable goodle drive portfolio and make sure you can fill client id and secret without warnings

      On php 5.6

      1. Enable portfolio
      2. go to manage portfolio
      3. enable goodle drive portfolio and make sure you can fill client id and secret without warnings
      Show
      On php 7.0.9 Enable portfolio go to manage portfolio enable goodle drive portfolio and make sure you can fill client id and secret without warnings On php 5.6 Enable portfolio go to manage portfolio enable goodle drive portfolio and make sure you can fill client id and secret without warnings
    • Affected Branches:
      MOODLE_31_STABLE, MOODLE_32_STABLE
    • Fixed Branches:
      MOODLE_30_STABLE, MOODLE_31_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      wip-MDL-56615-master
    • Pull Master Diff URL:

      Description

      Today while setting up portfolio on QA site, I encountered following error, and was not able to add Google drive portfolio.

      Warning: Parameter 1 to portfolio_plugin_googledocs::admin_config_form() expected to be a reference, value given in /var/www/vhosts/qamaster.moodle.net/html/lib/portfolio/forms.php on line 205

      Upgrading humanities to php 7.0.12 solved the issue.

      Steps to reproduce:

      1. Enable portfolio
      2. Go to Manage portfolio
      3. Enable Google drive portfolio and you will observe above error.
      4. There won't be a field for Client id and Secret

        Attachments

          Issue Links

          Discovered while testing

          Task - A task that needs to be completed. Tasks usually refer to work that must be done outside the product. MDLSITE-4779 Create a fresh 3.2 install of the QA testing site

          • Minor - Minor loss of function where workaround is possible
          • Resolved

            Activity

              People

              • Assignee:
                marina Marina Glancy
                Reporter:
                rajeshtaneja Rajesh Taneja
                Peer reviewer:
                John Okely
                Integrator:
                Eloy Lafuente (stronk7)
                Tester:
                Rajesh Taneja
                Participants:
                Component watchers:
                Amaia Anabitarte, Bas Brands, Carlos Escobedo, Sara Arjona (@sarjona), Víctor Déniz Falcón
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  14/Nov/16