Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-56619

theme_boost: File picker > selected file properties > fix dialog

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.2
    • Fix Version/s: 3.2
    • Component/s: Themes
    • Labels:
    • Testing Instructions:
      Hide
      1. Make sure you're using boost
      2. Log into moodle as admin
      3. Create a course
      4. In the course summary section click the "image" button to open the dialogue
      5. select "browser repositories"
      6. Search for something in the wikimedia repository
      7. Click on one of the results
      8. Confirm that the radio buttons at the top of the dialogue appear inline and to the left of the label text
      9. Confirm that you can still save the image as usual
      10. Repeat the test with a RTL language except:
        1. Confirm that the radio buttons are to the right of the label text
        2. Confirm that the image dimensions are displayed in LTR mode, e.g. 768 x 1024 px
        3. Note: The close icon might still be misaligned but that is being addressed in MDL-56778
      Show
      Make sure you're using boost Log into moodle as admin Create a course In the course summary section click the "image" button to open the dialogue select "browser repositories" Search for something in the wikimedia repository Click on one of the results Confirm that the radio buttons at the top of the dialogue appear inline and to the left of the label text Confirm that you can still save the image as usual Repeat the test with a RTL language except: Confirm that the radio buttons are to the right of the label text Confirm that the image dimensions are displayed in LTR mode, e.g. 768 x 1024 px Note: The close icon might still be misaligned but that is being addressed in MDL-56778
    • Affected Branches:
      MOODLE_32_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE
    • Pull Master Branch:
      MDL-56619-master

      Description

      Residue fixes after MDL-55729 was fixed:
      (1) The "X" closing button should be aligned to the left.
      (2) Image dimensions should be set as "direction:ltr;" and should not be RTLed as it is an exception to RTL where it should always be kept LTRed, as all numbers should.
      (3) Checkboxes are expected to be placed on the right side of the text.

      Theme Boost.

        Attachments

        1. ltr.png
          ltr.png
          40 kB
        2. snapshot113.png
          snapshot113.png
          40 kB

          Issue Links

            Activity

              People

              • Votes:
                1 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  5/Dec/16