Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-56646

Rescaling grades creates negative grades for students whose submission pages have been viewed, in assignments with grading guides

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Rescale test

      1. Create an assignment
      2. Select Marking Guide as the grading method
      3. Create a one or more criteria grading guide, Save it
      4. Grade any one student
      5. View any OTHER student's Grade screen
      6. Click Save without setting a grade
      7. Click "Edit Settings" under "Assignment Administration" in Admin block
      8. Select "Yes" to Rescale existing grades
      9. Change maximum grade to a number less than the current (for instance from 100 to 10)
      10. Save
      11. Click "View all submissions"
      12. Make sure the student in step 5 doesn't have a grade (negative or otherwise)

      Restore test

      1. On the last weekly (stable)
      2. Create an assignment and grade one student and look at and save but don't grade a bunch of other students.
      3. Rescale
      4. See view all submissions
      5. Make sure you have negative grades
      6. Back up your assignment
      7. Restore it on integration
      8. Make sure when you view it you don't have any negative grades in the assignment grading table

      Upgrade test

      1. Go to instance with the assignment with some negative grades from the last step
      2. Upgrade to the latest integration
      3. Go to the assignment
      4. Make sure you get the message telling you you have errant grades
      5. Make sure you can use the assignment and grade a student
      6. Click the link to fix grades
      7. Click cancel
      8. Make sure nothing changed
      9. Go to mod/assign/view.php?id=<ID HERE>&action=fixrescalednullgrades as a student. Make sure you get a warning saying you don't have the capability
      10. Go to mod/assign/view.php?id=<ID HERE> as a student. Make sure you don't see the errant grades warning
      11. Copy and paste mod/assign/view.php?id=<ID HERE>&action=fixrescalednullgrades&confirm=1 as a teacher. Make sure nothing happens, you just get an error (no sess key)
      12. Go back to the assignment
      13. Click the link to fix grades
      14. Click continue
      15. Go back to the assignment grading table, make sure there are no longer any negative grades
      Show
      Rescale test Create an assignment Select Marking Guide as the grading method Create a one or more criteria grading guide, Save it Grade any one student View any OTHER student's Grade screen Click Save without setting a grade Click "Edit Settings" under "Assignment Administration" in Admin block Select "Yes" to Rescale existing grades Change maximum grade to a number less than the current (for instance from 100 to 10) Save Click "View all submissions" Make sure the student in step 5 doesn't have a grade (negative or otherwise) Restore test On the last weekly (stable) Create an assignment and grade one student and look at and save but don't grade a bunch of other students. Rescale See view all submissions Make sure you have negative grades Back up your assignment Restore it on integration Make sure when you view it you don't have any negative grades in the assignment grading table Upgrade test Go to instance with the assignment with some negative grades from the last step Upgrade to the latest integration Go to the assignment Make sure you get the message telling you you have errant grades Make sure you can use the assignment and grade a student Click the link to fix grades Click cancel Make sure nothing changed Go to mod/assign/view.php?id=<ID HERE>&action=fixrescalednullgrades as a student. Make sure you get a warning saying you don't have the capability Go to mod/assign/view.php?id=<ID HERE> as a student. Make sure you don't see the errant grades warning Copy and paste mod/assign/view.php?id=<ID HERE>&action=fixrescalednullgrades&confirm=1 as a teacher. Make sure nothing happens, you just get an error (no sess key) Go back to the assignment Click the link to fix grades Click continue Go back to the assignment grading table, make sure there are no longer any negative grades
    • Affected Branches:
      MOODLE_31_STABLE, MOODLE_33_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE, MOODLE_33_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-56646-master
    • Sprint:
      3.4 Sprint 4

      Description

      To reproduce:

      1. Create an assignment
      2. Select Marking Guide as the grading method
      3. Create a one or more criteria grading guide, Save it
      4. Grade any one student
      5. View any OTHER student's Grade screen
      6. No need to click Save
      7. Click "Edit Settings" under "Assignment Administration" in Admin block
      8. Select "Yes" to Rescale existing grades
      9. Change maximum grade to a number less than the current (for instance from 100 to 10)
      10. Save
      11. Click "View all submissions"
      12. The student in step 5 will now have a negative grade

        Attachments

        1. assigngradingtable.png
          assigngradingtable.png
          24 kB
        2. assign-regrade.png
          assign-regrade.png
          65 kB
        3. fixrescalednullgrades.png
          fixrescalednullgrades.png
          64 kB
        4. fixrescalednullgrades.png
          fixrescalednullgrades.png
          69 kB
        5. fixrescalednullgradesconfirm.png
          fixrescalednullgradesconfirm.png
          26 kB
        6. fixrescalednullgradesconfirm.png
          fixrescalednullgradesconfirm.png
          44 kB
        7. fixrescalednullgradesdone.png
          fixrescalednullgradesdone.png
          18 kB
        8. fixrescalednullgradesdone.png
          fixrescalednullgradesdone.png
          21 kB
        9. gradebook.png
          gradebook.png
          26 kB
        10. grading.png
          grading.png
          50 kB
        11. MDL-56646-unit-test-attempt.diff
          6 kB
        12. negativegrades.mbz
          415 kB

          Activity

            People

            Assignee:
            johno John Okely
            Reporter:
            lindn Nathan Lind
            Peer reviewer:
            Adrian Greeve
            Integrator:
            Andrew Nicols
            Tester:
            David Monllaó
            Participants:
            Component watchers:
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
            Votes:
            5 Vote for this issue
            Watchers:
            13 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              11/Sep/17