[MDL-56653] DB Query in loop in enrol/meta/lib.php::edit_instance_validation - Moodle Tracker

XML

Word

Printable

Affected Branches:
MOODLE_31_STABLE, MOODLE_32_STABLE
Fixed Branches:
MOODLE_310_STABLE, MOODLE_39_STABLE
Pull from Repository:
git://github.com/lameze/moodle.git
Pull 3.9 Branch:
~~MDL-56653~~-39
Pull 3.9 Diff URL:
https://github.com/lameze/moodle/compare/a3f72b3972...MDL-56653-39
Pull 3.11 Branch:
~~MDL-56653~~-311
Pull 3.11 Diff URL:
https://github.com/lameze/moodle/compare/b4274fe6da...MDL-56653-311
Pull Master Branch:
~~MDL-56653~~_enrol_meta_edit_instance_validation
Pull Master Diff URL:
https://github.com/moodle/moodle/compare/master...vtos:MDL-56653_enrol_meta_edit_instance_validation?expand=1
Testing Instructions:
1. The unit test added should ensure that the logic wasn't affected when tweaking performance.
2. Code analysis should reveal that the number of DB queries to fetch existing enrolment instances was reduced to 1.

The edit_instance_validation function checks for existing meta enrolment instances.
It does so in a loop.

It should ideally fetch all of them in a single query, indexed by the course being meta-linked.

Discovered while testing

MDL-56282 Cannot edit an instances Course meta enrolment

has been marked as being related by

MDL-70967 Error in test enrol/meta/tests/plugin_test.php

Participants:: Adrian Greeve, Andrew Lyons, CiBoT, Eloy Lafuente (stronk7), Marina Glancy, Matteo Scaramuccia, Simey Lameze, Vitaly Potenko

Component watchers:: David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo, Matteo Scaramuccia, David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo

Estimated:

Not Specified

Remaining:

Logged:

7h 25m