Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-56659

Problems with password unmask templates and plain password field in noscript mode

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      Automated test
      1. Run behat with --tags=~@javascript or wait for nightly to report
      Manual test (on clean, boost and snap theme)
      1. Visit following pages and check:
        • Site administration ► Security ► Site policies
        • Preferences ► User account ► Edit profile
      2. Check dom for password unmask
        • There should be no noscript tag.
        • Check hidden input element and size should not be set.
      3. Click on edit icon and check dom for input text element and it should have size set.
        • Ensure filed looks similar to other input text fields.
      4. Click outside password field (anywhere on page), to hide password field.
      5. Click on password unmask label and ensure the field is visible.
      6. Add/Edit/Delete values in password unmask field and make sure there is no problem.
      Exploratory testing
      • As this is a significant change and we are close to release, please carry out exploratory testing on the unmask element in a series of different browsers and situations and ensure its working robustly
      Show
      Automated test Run behat with --tags=~@javascript or wait for nightly to report Manual test (on clean, boost and snap theme) Visit following pages and check: Site administration ► Security ► Site policies Preferences ► User account ► Edit profile Check dom for password unmask There should be no noscript tag. Check hidden input element and size should not be set. Click on edit icon and check dom for input text element and it should have size set. Ensure filed looks similar to other input text fields. Click outside password field (anywhere on page), to hide password field. Click on password unmask label and ensure the field is visible. Add/Edit/Delete values in password unmask field and make sure there is no problem. Exploratory testing As this is a significant change and we are close to release, please carry out exploratory testing on the unmask element in a series of different browsers and situations and ensure its working robustly
    • Affected Branches:
      MOODLE_32_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE
    • Pull Master Branch:
      wip-mdl-56659

      Description

      admin/templates/setting_configpasswordunmask.mustache

      (#1) HTML Validation error, line 11: Attribute “size” not allowed on element “input” at this point. ( <input type="hidden" name="test" id="test0" value="secret" size="8" > )
      (#1) HTML Validation error, line 35: Duplicate ID “test0”. ( <input type="password" name="test" id="test0" value="secret" size="8" > )
      (#1) HTML Validation info, line 11: The first occurrence of ID “test0” was here. ( <input type="hidden" name="test" id="test0" value="secret" size="8" > )

      theme/boost/templates/core_admin/setting_configpasswordunmask.mustache

      (#1) HTML Validation error, line 12: Attribute “size” not allowed on element “input” at this point. ( <input type="hidden" name="test" id="test0" value="secret" size="8" class="form-control d-inline-block" > )
      (#1) HTML Validation error, line 37: Duplicate ID “test0”. ( <input type="password" name="test" id="test0" value="secret" size="8" class="form-control d-inline-block" > )
      (#1) HTML Validation info, line 12: The first occurrence of ID “test0” was here. ( <input type="hidden" name="test" id="test0" value="secret" size="8" class="form-control d-inline-block" > )

      theme/boost/templates/core_form/element-passwordunmask.mustache - WARNING: HTML Validation error, line 19: Attribute “size” not allowed on element “input” at this point. ( <input type="hidden" name="example" id="example_password_unmask" value="Password1!" class="form-control d-inline-block " size="40" > )

      /Users/danp/www/im/theme/boost/templates/core_form/element-passwordunmask.mustache - WARNING: HTML Validation error, line 46: Duplicate ID “example_password_unmask”. ( <input type="password" name="example" id="example_password_unmask" value="Password1!" class="form-control d-inline-block " size="40" > )
      /Users/danp/www/im/theme/boost/templates/core_form/element-passwordunmask.mustache - WARNING: HTML Validation info, line 19: The first occurrence of ID “example_password_unmask” was here. ( <input type="hidden" name="example" id="example_password_unmask" value="Password1!" class="form-control d-inline-block " size="40" > )

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  5/Dec/16