Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-56698

theme_boost: Feedback activity view page is all jumbled

    XMLWordPrintable

Details

    • MOODLE_32_STABLE
    • MOODLE_32_STABLE
    • MDL-56698-master
    • Hide
      1. Restore the attached backup and navigate to the newly created feedback
      2. foreach ($theme in ['clean', 'boost',]) {
        1. View the "Templates" page
          1. Confirm that the Public checkbox only says public once
        2. As a student view the feedback and choose to Answer the questions
          1. Confirm that the items are in reasonable alignment*
          2. Confirm that the buttons at the bottom are on the same line*
      3. }

      Note - the placement of the menus and move arrows on edit questions page is not great. This is a crap form with action menus and drag and drop controls embedded in the field labels. I can't do better.

      Show
      Restore the attached backup and navigate to the newly created feedback foreach ($theme in ['clean', 'boost',] ) { View the "Templates" page Confirm that the Public checkbox only says public once As a student view the feedback and choose to Answer the questions Confirm that the items are in reasonable alignment* Confirm that the buttons at the bottom are on the same line* } Note - the placement of the menus and move arrows on edit questions page is not great. This is a crap form with action menus and drag and drop controls embedded in the field labels. I can't do better.

    Description

      After MDL-56188 got in, feedback form is all jumbled and is causing behat failure on chrome.

      Steps to reproduce:

      1. Run mod/feedback/tests/behat/question_types_non_anon.feature and view when student log in and access feedback activity.

      In chrome you will observe following failure:

      001 Scenario: Create different types of questions in non-anonymous feedback with javascript enabled # /home/rajesh/moodles/im/moodle/mod/feedback/tests/behat/question_types_non_anon.feature:8
      		 
            And I set the following fields to these values:                                               # /home/rajesh/moodles/im/moodle/mod/feedback/tests/behat/question_types_non_anon.feature:77
      		 
              unknown error: Element is not clickable at point (84, 542). Other element would receive the click: <label class="col-form-label d-inline " for="id_multichoice_332006_0">...</label>
      		 
                (Session info: chrome=53.0.2785.143)
      		 
                (Driver info: chromedriver=2.21.371461 (633e689b520b25f3e264a2ede6b74ccc23cb636a),platform=Linux 4.4.0-38-generic x86_64) (WARNING: The server did not provide any stacktrace information)
      		 
              Command duration or timeout: 20 milliseconds
      		 
              Build info: version: '2.53.1', revision: 'a36b8b1', time: '2016-06-30 17:37:03'
      		 
              System info: host: 'raji', ip: '127.0.1.1', os.name: 'Linux', os.arch: 'amd64', os.version: '4.4.0-38-generic', java.version: '1.8.0_91'
      		 
              Driver info: org.openqa.selenium.chrome.ChromeDriver
      		 
              Capabilities [{applicationCacheEnabled=false, rotatable=false, mobileEmulationEnabled=false, chrome={chromedriverVersion=2.21.371461 (633e689b520b25f3e264a2ede6b74ccc23cb636a), userDataDir=/tmp/.com.google.Chrome.q3NXnG}, takesHeapSnapshot=true, databaseEnabled=false, handlesAlerts=true, hasTouchScreen=false, version=53.0.2785.143, platform=LINUX, browserConnectionEnabled=false, nativeEvents=true, acceptSslCerts=true, locationContextEnabled=true, webStorageEnabled=true, browserName=chrome, takesScreenshot=true, javascriptEnabled=true, cssSelectorsEnabled=true}]
      		 
              Session ID: b1779dbadfd0fc22cbb64ace5d60dee6 (WebDriver\Exception\UnknownError)

      Attachments

        Issue Links

          is a regression caused by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-56188 theme_boost: help icon placement on long labels

          • Minor - Minor loss of function where workaround is possible
          • Closed
          is duplicated by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-56701 Behat failure in questions type feature

          • Minor - Minor loss of function where workaround is possible
          • Closed
          Testing discovered

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-56709 theme_boost: Feedback activity edit question menu badly positioned

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Activity

            People

              damyon Damyon Wiese
              rajeshtaneja Rajesh Taneja
              Rajesh Taneja Rajesh Taneja
              Andrew Lyons Andrew Lyons
              Jake Dallimore Jake Dallimore
              Amaia Anabitarte, Carlos Escobedo, Laurent David, Mikel Martín Corrales, Sabina Abellan, Sara Arjona (@sarjona), Huong Nguyen, Bas Brands, Mathew May, Amaia Anabitarte, Carlos Escobedo, Laurent David, Mikel Martín Corrales, Sabina Abellan, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                5/Dec/16