Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-5684

frameset page in UTF8 doesn't appear on IE

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.6
    • Fix Version/s: None
    • Component/s: Workshop
    • Labels:
      None
    • Environment:
      All
    • Database:
      Any
    • Affected Branches:
      MOODLE_16_STABLE

      Description

      In some pages that use <frameset> in Workshop, Internet Explorer sometimes can't recognize the <title> ... </title> pair when the bounded title string is in UTF8, so just an empty page appears. It is because the page is without the charset meta header and IE misrecognize the charset.

      For mod/workshop/assess.php and mod/workshop/viewassessment.php, I propose the following modification:

      — mod/workshop/assess.php.orig0 2006-06-01 19:33:37.000000000 +0900

      +++ mod/workshop/assess.php 2006-06-01 20:31:19.000000000 +0900

      @@ -36,6 +36,10 @@

      /// Now check whether we need to display a frameset

      if (empty($frameset)) {

      + // t-kita 2006-0601

      + $encoding = current_charset();

      + echo '<meta http-equiv=content-type content=text/html; charset='. $encoding .' />'. \n;

      +

      echo <head><title>{$course->shortname}: .format_string($workshop->name,true).</title></head>\n;

      echo <frameset rows=\50%,*\ border=\10\>;

      echo <frame src=\assess.php?id=$id&sid=$sid&frameset=top&redirect=$redirect\ border=\10\>;

      — mod/workshop/viewassessment.php.orig0 2006-05-04 14:42:09.000000000 +0900

      +++ mod/workshop/viewassessment.php 2006-06-01 20:32:17.000000000 +0900

      @@ -38,6 +38,10 @@

      /// Now check whether we need to display a frameset

      if (empty($frameset)) {

      + // t-kita 2006-0601

      + $encoding = current_charset();

      + echo '<meta http-equiv=content-type content=text/html; charset='. $encoding .' />'. \n;

      +

      echo <head><title>{$course->shortname}: .format_string($workshop->name,true).</title></head>\n;

      echo <frameset rows=\90%,*\ border=\10\>;

      echo <frame src=\viewassessment.php?id=$id&aid=$aid&allowcomments=$allowcomments&frameset=top&redirect=$\

      redirect\ border=\10\>;

        Attachments

          Activity

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: