Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-56841

Folder: Buttons to edit and download folder are not shown when folder is displayed on the course page

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.1.2
    • Fix Version/s: 3.1.5, 3.2.2
    • Component/s: Resource
    • Labels:
    • Testing Instructions:
      Hide
      Test 1
      1. Log in as an admin.
      2. Create a folder activity in a course with a file and set 'Display folder contents' to 'On a separate page' and 'Show download folder button' to checked.
      3. Confirm these buttons are not shown on the course page.
      4. Click on the folder and ensure you get to the new page that contain these buttons.
      Test 2
      1. Log in as an admin.
      2. Create a folder activity in a course with a file and set 'Display folder contents' to 'Inline on the course page' and 'Show download folder button' to checked.
      3. Confirm there is a button displayed on the course page beneath the folder listing that allow the user to download the folder as an archive but that there is no edit button (the user has the ability to edit the activity if they wish).
      Test 3
      1. Log in as an admin.
      2. Create a folder activity in a course with a file and set 'Display folder contents' to On a separate page' and 'Show download folder button' to unchecked.
      3. Confirm these buttons are not shown on the course page.
      4. Click on the folder and ensure you get to the new page that only contains the edit button.
      Test 4
      1. Log in as an admin.
      2. Create a folder activity in a course with a file and set 'Display folder contents' to 'Inline on the course page' and 'Show download folder button' to unchecked.
      3. Confirm there are no buttons displayed on the course page beneath the folder listing.
      Test 5
      1. Log in as an admin.
      2. Create a folder activity in a course with no files and set 'Display folder contents' to 'On a separate page' and 'Show download folder button' to checked.
      3. Confirm these buttons are not shown on the course page.
      4. Click on the folder and ensure you get to the new page that only includes an 'Edit' button (nothing to download).
      Test 6
      1. Log in as an admin.
      2. Create a folder activity in a course with no files and set 'Display folder contents' to 'Inline on the course page' and 'Show download folder button' to checked.
      3. Confirm there are no buttons displayed on the course page beneath the folder listing (the user has the ability to edit the activity if they wish and there is nothing to download).
      Test 7
      1. Log in as an admin.
      2. Edit the 'Student' role via 'Site administration' > 'Users' > 'Permissions' > 'Define roles'.
      3. Set the capability 'mod/folder:managefiles' to Allow.
      4. Create a folder activity in a course with a file and set 'Display folder contents' to 'On a separate page' and 'Show download folder button' to checked.
      5. Enrol a student into the course.
      6. Log in as the student.
      7. Visit the course.
      8. Confirm these buttons are not shown on the course page.
      9. Click on the folder link.
      10. Confirm the buttons are shown there and work as expected.
      Test 8
      1. Log in as an admin.
      2. Edit the 'Student' role via 'Site administration' > 'Users' > 'Permissions' > 'Define roles'.
      3. Set the capability 'mod/folder:managefiles' to Allow.
      4. Create a folder activity in a course with a file and set 'Display folder contents' to 'Inline on the course page' and 'Show download folder button' to checked.
      5. Enrol a student into the course.
      6. Log in as the student.
      7. Visit the course.
      8. Confirm these buttons are shown on the course page and work as expected.
      Test 9
      1. Log in as an admin.
      2. Edit the 'Student' role via 'Site administration' > 'Users' > 'Permissions' > 'Define roles'.
      3. Set the capability 'mod/folder:managefiles' to Allow.
      4. Create a folder activity in a course with no files and set 'Display folder contents' to 'On a separate page' and 'Show download folder button' to checked.
      5. Enrol a student into the course.
      6. Log in as the student.
      7. Visit the course.
      8. Confirm these buttons are not shown on the course page.
      9. Click on the folder link.
      10. Click on the folder and ensure you get to the new page that only includes an 'Edit' button (nothing to download).
      Test 10
      1. Log in as an admin.
      2. Edit the 'Student' role via 'Site administration' > 'Users' > 'Permissions' > 'Define roles'.
      3. Set the capability 'mod/folder:managefiles' to Allow.
      4. Create a folder activity in a course with no files and set 'Display folder contents' to 'Inline on the course page' and 'Show download folder button' to checked.
      5. Enrol a student into the course.
      6. Log in as the student.
      7. Visit the course.
      8. Confirm there is is only an 'Edit' button displayed on the course page beneath the folder listing (nothing to download).
      Test 11
      1. Log in as an admin and revert your changes to the student role (uncheck 'Allow' for the 'mod/folder:managefiles' capability).
      2. Log in as the student and check the folders you created earlier while testing.
      3. Confirm you never see an edit button for them (both separate and inline).
      Show
      Test 1 Log in as an admin. Create a folder activity in a course with a file and set 'Display folder contents' to 'On a separate page' and 'Show download folder button' to checked. Confirm these buttons are not shown on the course page. Click on the folder and ensure you get to the new page that contain these buttons. Test 2 Log in as an admin. Create a folder activity in a course with a file and set 'Display folder contents' to 'Inline on the course page' and 'Show download folder button' to checked. Confirm there is a button displayed on the course page beneath the folder listing that allow the user to download the folder as an archive but that there is no edit button (the user has the ability to edit the activity if they wish). Test 3 Log in as an admin. Create a folder activity in a course with a file and set 'Display folder contents' to On a separate page' and 'Show download folder button' to unchecked. Confirm these buttons are not shown on the course page. Click on the folder and ensure you get to the new page that only contains the edit button. Test 4 Log in as an admin. Create a folder activity in a course with a file and set 'Display folder contents' to 'Inline on the course page' and 'Show download folder button' to unchecked. Confirm there are no buttons displayed on the course page beneath the folder listing. Test 5 Log in as an admin. Create a folder activity in a course with no files and set 'Display folder contents' to 'On a separate page' and 'Show download folder button' to checked. Confirm these buttons are not shown on the course page. Click on the folder and ensure you get to the new page that only includes an 'Edit' button (nothing to download). Test 6 Log in as an admin. Create a folder activity in a course with no files and set 'Display folder contents' to 'Inline on the course page' and 'Show download folder button' to checked. Confirm there are no buttons displayed on the course page beneath the folder listing (the user has the ability to edit the activity if they wish and there is nothing to download). Test 7 Log in as an admin. Edit the 'Student' role via 'Site administration' > 'Users' > 'Permissions' > 'Define roles'. Set the capability 'mod/folder:managefiles' to Allow. Create a folder activity in a course with a file and set 'Display folder contents' to 'On a separate page' and 'Show download folder button' to checked. Enrol a student into the course. Log in as the student. Visit the course. Confirm these buttons are not shown on the course page. Click on the folder link. Confirm the buttons are shown there and work as expected. Test 8 Log in as an admin. Edit the 'Student' role via 'Site administration' > 'Users' > 'Permissions' > 'Define roles'. Set the capability 'mod/folder:managefiles' to Allow. Create a folder activity in a course with a file and set 'Display folder contents' to 'Inline on the course page' and 'Show download folder button' to checked. Enrol a student into the course. Log in as the student. Visit the course. Confirm these buttons are shown on the course page and work as expected. Test 9 Log in as an admin. Edit the 'Student' role via 'Site administration' > 'Users' > 'Permissions' > 'Define roles'. Set the capability 'mod/folder:managefiles' to Allow. Create a folder activity in a course with no files and set 'Display folder contents' to 'On a separate page' and 'Show download folder button' to checked. Enrol a student into the course. Log in as the student. Visit the course. Confirm these buttons are not shown on the course page. Click on the folder link. Click on the folder and ensure you get to the new page that only includes an 'Edit' button (nothing to download). Test 10 Log in as an admin. Edit the 'Student' role via 'Site administration' > 'Users' > 'Permissions' > 'Define roles'. Set the capability 'mod/folder:managefiles' to Allow. Create a folder activity in a course with no files and set 'Display folder contents' to 'Inline on the course page' and 'Show download folder button' to checked. Enrol a student into the course. Log in as the student. Visit the course. Confirm there is is only an 'Edit' button displayed on the course page beneath the folder listing (nothing to download). Test 11 Log in as an admin and revert your changes to the student role (uncheck 'Allow' for the 'mod/folder:managefiles' capability). Log in as the student and check the folders you created earlier while testing. Confirm you never see an edit button for them (both separate and inline).
    • Affected Branches:
      MOODLE_31_STABLE
    • Fixed Branches:
      MOODLE_31_STABLE, MOODLE_32_STABLE
    • Pull from Repository:
    • Pull Master Branch:
    • Pull Master Diff URL:

      Description

      • I have a new role that is a copy of student and is named "FolderOwner": only change is, that the role student: mod/folder:managefiles is set "allowed"
      • I have a folder X in a certain course
      • I assign the role FolderOwner for the folder X to a student

      This works:

      • I set "Display folder content" to "On a seperate page" for folder X
        => I cklick on the folder an get to the new page with an "Edit"-Button => works as intended

      This does not work:

      • I set "Display folder content" to "inline on the course page" for folder X
        => there is no possibility to manage the files in the folder now

        Attachments

          Issue Links

          has been marked as being related by

          Improvement - An enhancement to an existing Moodle feature. MDL-51306 Bulk download all files within a folder activity as ZIP file

          • Major - Major loss of function, incorrect output
          • Closed

          Improvement - An enhancement to an existing Moodle feature. MDL-38368 Folder displayed on course page should not display "Edit" button

          • Minor - Minor loss of function where workaround is possible
          • Closed
          is blocked by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-58305 Missing edit button at folder ressource if dispayed inline on the course page.

          • Minor - Minor loss of function where workaround is possible
          • Reopened
          is duplicated by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-60075 No "Edit Button" on the Activity "folder"

          • Minor - Minor loss of function where workaround is possible
          • Closed

            Activity

              People

              Assignee:
              andrew_dc_hancox Andrew Hancox
              Reporter:
              eibel66 Eibel Thomas
              Peer reviewer:
              Mark Nelson
              Integrator:
              Dan Poltawski
              Tester:
              Rajesh Taneja
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                13/Mar/17