Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-56858

boost: Checkbox label and description appear on the same line causing confusion

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.2
    • Fix Version/s: 3.2
    • Component/s: Themes
    • Labels:
    • Testing Instructions:
      Hide
      Test 1
      1. Switch to the 'Boost' theme if you are not already using it.
      2. Add the following code located at https://gist.github.com/markn86/d5986f9aaad68286e9154f61a706c187 to test.php in your wwwroot.
      3. Visit <yoursite>/test.php.
      4. Ensure that when the label AND text is provided the label is on the left and the text is on the right of the input field.
      5. Ensure that when just the label is provided the label is on the right of the input field.
      6. Ensure that when just the text is provided the text is on the right of the input field.
      7. For the elements in the group ensure they all appear on the same row and the 'Text' is in <em> tags.
      8. Confirm the advanced symbol is shown on all elements.
      9. Confirm the required symbol is shown on only the radio buttons and group.
      Test 2
      1. Test on clean but this time just make sure it looks how it did on stables.
      Test 3
      1. Ensure Behat isn't having a sad.
      Show
      Test 1 Switch to the 'Boost' theme if you are not already using it. Add the following code located at https://gist.github.com/markn86/d5986f9aaad68286e9154f61a706c187 to test.php in your wwwroot. Visit <yoursite>/test.php. Ensure that when the label AND text is provided the label is on the left and the text is on the right of the input field. Ensure that when just the label is provided the label is on the right of the input field. Ensure that when just the text is provided the text is on the right of the input field. For the elements in the group ensure they all appear on the same row and the 'Text' is in <em> tags. Confirm the advanced symbol is shown on all elements. Confirm the required symbol is shown on only the radio buttons and group. Test 2 Test on clean but this time just make sure it looks how it did on stables. Test 3 Ensure Behat isn't having a sad.
    • Affected Branches:
      MOODLE_32_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-56858_master-alt-2

      Description

      Eg.

      $mform->addElement('checkbox', 'the_name_of_checkbox', 'Label', 'Text');
      

      In Clean 'Label' appears in bold on the left of the checkbox, where as in Boost it appears in the same font and position as 'Text' on the right of the checkbox.

        Attachments

        1. activity_completion_with_alt_2_patch.png
          activity_completion_with_alt_2_patch.png
          25 kB
        2. activity_completion_with_alt_patch.png
          activity_completion_with_alt_patch.png
          25 kB
        3. activity_completion_with_original_patch.png
          activity_completion_with_original_patch.png
          27 kB
        4. activity completion settings forum.png
          activity completion settings forum.png
          31 kB
        5. advanced.png
          advanced.png
          88 kB
        6. boost.png
          boost.png
          37 kB
        7. clean.png
          clean.png
          39 kB
        8. screenshot-1.png
          screenshot-1.png
          42 kB

          Issue Links

            Activity

              People

              • Votes:
                1 Vote for this issue
                Watchers:
                11 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  5/Dec/16