Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-56865

PHP Notices thrown as fatal errors during Behat setup

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Revert the changes in MDL-57007 (these changes mean no notices in the below testing scenario!)
      2. clone oembed under {moodle_path}

        /filter

      3. git clone --depth=50 --branch=MOODLE_32_ALPHA https://github.com/POETGroup/moodle-filter_oembed.git oembed
      4. git checkout -qf 6d6786df209a49620f7ddc3ca24083b2e818ecee
      5. php admin/tool/behat/cli/init.php
      6. Ensure you see curl notice, but install should not fail.
      Show
      Revert the changes in MDL-57007 (these changes mean no notices in the below testing scenario!) clone oembed under {moodle_path} /filter git clone --depth=50 --branch=MOODLE_32_ALPHA https://github.com/POETGroup/moodle-filter_oembed.git oembed git checkout -qf 6d6786df209a49620f7ddc3ca24083b2e818ecee php admin/tool/behat/cli/init.php Ensure you see curl notice, but install should not fail.
    • Affected Branches:
      MOODLE_31_STABLE
    • Fixed Branches:
      MOODLE_31_STABLE
    • Pull Master Branch:
      wip-mdl-56865

      Description

      When setting up Behat for Moodle 3.1.2 on our system we are no longer able to get the init process to complete. The error was traced down to MDL-46514.

      This patch introduced in Moodle 3.1.2 surfaced PHP notices and such as Fatal errors for AJAX scripts.

      But in doing so, it also surfaced those errors as fatal errors during CLI scripts (such as the Behat init script).

      With some 3rd party plugins, they attempt to use undefined properties in their settings.php.

      For example:

      !!! Exception - Notice: Undefined index: REQUEST_URI in [dirroot]/mod/mediasite/settings.php on line 11 !!!
      

      !!! Exception - Notice: Undefined property: stdClass::$sessioncookie in [dirroot]/blocks/lockdownbrowser/settings.php on line 143 !!!
      

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  9/Jan/17