Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-56870

Course modules can be viewed after adhoc deletion is scheduled

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      As a teacher

      1. Create and activity and view it.
      2. Save the URL somewhere
      3. Edit the activity
      4. Copy that URL somewhere too
      5. Delete the activity
      6. For each of the 2 saved URLs:
        • Visit the URL
        • Confirm that you see a notification stating that the activity is being deleted.
      7. Repeat the URL-pasting exercise as a manager, admin and student (view only) confirming that you get the notification each time.
      Show
      As a teacher Create and activity and view it. Save the URL somewhere Edit the activity Copy that URL somewhere too Delete the activity For each of the 2 saved URLs: Visit the URL Confirm that you see a notification stating that the activity is being deleted. Repeat the URL-pasting exercise as a manager, admin and student (view only) confirming that you get the notification each time.
    • Affected Branches:
      MOODLE_32_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-56870-master-v2

      Description

      Since we now have backgrounded activity deletion (MDL-54751), we need to prevent deleted modules being accessed via the mod/XXX/view.php?id=1 pages.

      To replicate the problem:

      1. Create and activity and view it.
      2. Copy the URL
      3. Delete the activity
      4. Paste the copied URL and notice that you can still see the activity.

      Perhaps something like require_login (which already uses modinfo cache) can be used to restrict access to modules marked as 'deletioninprogress'.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              jaked Jake Dallimore
              Reporter:
              jaked Jake Dallimore
              Peer reviewer:
              Dan Poltawski
              Integrator:
              David Monllaó
              Tester:
              Ankit Agarwal
              Participants:
              Component watchers:
              Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón, Barbara Ramiro, Bas Brands
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                5/Dec/16