Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-56902

When switching back and forth from boost to clean dont add blocks to boost

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 3.2
    • Fix Version/s: 3.2
    • Component/s: Blocks, Themes
    • Labels:
    • Testing Instructions:
      Hide

      On a new install with boost.

      Check there is no nav or settings blocks.

      Switch to clean. Check the nav / settings blocks appears.

      Switch back to boost. Check the nav / settings blocks are not visible.

      Check you can add a nav / settings block.

      Switch back to clean. Check there are not 2 nav or settings blocks.

      Switch back to boost. Delete the nav / settings blocks.

      Switch back to clean.

      Rearrange the nav and settings blocks.

      Switch back to boost.

      Verify the nav / settings blocks are not visible.

      Create a quiz

      Login as a teacher, edit the settings for a quiz and set 'Show blocks during quiz attempts' to yes (in Appearance, click 'Show more...').
      Turn editing on and click "Preview quiz now"
      Add a block, such as Comments or an HTML block to the quiz page.
      Login as a student, attempt the quiz and check that the block that the teacher added is displayed on the quiz attempt pages.
      Login as the teacher, change theme to clean, edit the quiz settings and set 'Show blocks during quiz attempts' to no, save changes and click "Preview quiz now"
      Login as the student, attempt the quiz and check that the block is no longer displayed on the quiz attempt pages.
      Login as the teacher again, change theme to clean, edit the quiz settings and set 'Show blocks during quiz attempts' to yes, save changes and click "Preview quiz now"
      Login as the student, attempt the quiz, there is not 2 navigation blocks.

      Show
      On a new install with boost. Check there is no nav or settings blocks. Switch to clean. Check the nav / settings blocks appears. Switch back to boost. Check the nav / settings blocks are not visible. Check you can add a nav / settings block. Switch back to clean. Check there are not 2 nav or settings blocks. Switch back to boost. Delete the nav / settings blocks. Switch back to clean. Rearrange the nav and settings blocks. Switch back to boost. Verify the nav / settings blocks are not visible. Create a quiz Login as a teacher, edit the settings for a quiz and set 'Show blocks during quiz attempts' to yes (in Appearance, click 'Show more...'). Turn editing on and click "Preview quiz now" Add a block, such as Comments or an HTML block to the quiz page. Login as a student, attempt the quiz and check that the block that the teacher added is displayed on the quiz attempt pages. Login as the teacher, change theme to clean, edit the quiz settings and set 'Show blocks during quiz attempts' to no, save changes and click "Preview quiz now" Login as the student, attempt the quiz and check that the block is no longer displayed on the quiz attempt pages. Login as the teacher again, change theme to clean, edit the quiz settings and set 'Show blocks during quiz attempts' to yes, save changes and click "Preview quiz now" Login as the student, attempt the quiz, there is not 2 navigation blocks.
    • Affected Branches:
      MOODLE_32_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-56902-master

      Description

      The nav and settings block should not be restored permanently when switching themes. This is a tricky thing because the blocks have config like order, which pages to display on etc. It must be possible to store a flag somewhere to have a theme specific block.

      Also for existing sites switching to boost the default settings and nav block instances should go.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                8 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  5/Dec/16