Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-56904

Cannot inherit theme_boost

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Blocker
    • Resolution: Duplicate
    • Affects Version/s: 3.2
    • Fix Version/s: None
    • Component/s: Themes
    • Labels:
      None
    • Affected Branches:
      MOODLE_32_STABLE

      Description

      When you inherit theme_boost, the get_pre_scss function grabs all the scss and passes it to the compile method on top of the rest of the theme's scss.
      The problem is the imports are relative to the new theme, so "@import moodle" does not find a file as it exists in theme_boost, not the new theme. You therefore get no scss from theme_boost, except a little in the preset which promptly breaks it.

      If you create a moodle.scss and @import ../../boost/scss/moodle it works around the issue but I think a proper fix needs to be found. Unfortunately I am away for the next 10 weeks so cannot look into this

      A workaround is to allow the child theme to override the theme_boost_get_pre_scss, rather than add alongside it.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              Unassigned Unassigned
              Reporter:
              skylarkelty Skylar Kelty
              Participants:
              Component watchers:
              Bas Brands
              Votes:
              1 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: