Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-56910

Boost: File chooser form button bad styling

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.2
    • Fix Version/s: 3.2
    • Component/s: Themes
    • Labels:
    • Testing Instructions:
      Hide
      1. In clean and boost
      2. Go to the 'add group' form
      3. In boost verify that the picture chooser button is styled like the rest of boost's buttons
      4. In clean verify that it looks like it was before in stables (font size will be a little bigger)
      5. Go to 'manage calendar subscriptions' page in clean
      6. Verify the file picker button looks the same when disabled (when url is selected) as it did before the patch
      Show
      In clean and boost Go to the 'add group' form In boost verify that the picture chooser button is styled like the rest of boost's buttons In clean verify that it looks like it was before in stables (font size will be a little bigger) Go to 'manage calendar subscriptions' page in clean Verify the file picker button looks the same when disabled (when url is selected) as it did before the patch
    • Affected Branches:
      MOODLE_32_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE
    • Pull Master Branch:
      MDL-56910-master

      Description

      For example on the 'add groups' form:

      Note that we do have this rule in ur scss:

      input {
          &.fp-btn-choose {
              @extend .btn-sm;
          }
      }
      

      It kind of looks to me like it would bet better as .form-control-file but its not quite the same fit

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  1 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    5/Dec/16