Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-56910

Boost: File chooser form button bad styling

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Minor
    • 3.2
    • 3.2
    • Themes
    • MOODLE_32_STABLE
    • MOODLE_32_STABLE
    • MDL-56910-master
    • Hide
      1. In clean and boost
      2. Go to the 'add group' form
      3. In boost verify that the picture chooser button is styled like the rest of boost's buttons
      4. In clean verify that it looks like it was before in stables (font size will be a little bigger)
      5. Go to 'manage calendar subscriptions' page in clean
      6. Verify the file picker button looks the same when disabled (when url is selected) as it did before the patch
      Show
      In clean and boost Go to the 'add group' form In boost verify that the picture chooser button is styled like the rest of boost's buttons In clean verify that it looks like it was before in stables (font size will be a little bigger) Go to 'manage calendar subscriptions' page in clean Verify the file picker button looks the same when disabled (when url is selected) as it did before the patch

    Description

      For example on the 'add groups' form:

      Note that we do have this rule in ur scss:

      input {
          &.fp-btn-choose {
              @extend .btn-sm;
          }
      }
      

      It kind of looks to me like it would bet better as .form-control-file but its not quite the same fit

      Attachments

        Issue Links

          Activity

            People

              poltawski Dan Poltawski
              poltawski Dan Poltawski
              John Okely John Okely
              Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
              Ankit Agarwal Ankit Agarwal
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Clockify

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.