[MDL-56910] Boost: File chooser form button bad styling - Moodle Tracker

XML

Word

Printable

Affected Branches:
MOODLE_32_STABLE
Fixed Branches:
MOODLE_32_STABLE
Pull from Repository:
git://github.com/danpoltawski/moodle.git
Pull Main Branch:
~~MDL-56910~~-master
Pull Main Diff URL:
https://github.com/danpoltawski/moodle/compare/258d07d37ef719d0f1842f2a74113fd64e1ead40...MDL-56910-master
Testing Instructions:
Hide

In clean and boost

Go to the 'add group' form

In boost verify that the picture chooser button is styled like the rest of boost's buttons

In clean verify that it looks like it was before in stables (font size will be a little bigger)

Go to 'manage calendar subscriptions' page in clean

Verify the file picker button looks the same when disabled (when url is selected) as it did before the patch
Show
In clean and boost Go to the 'add group' form In boost verify that the picture chooser button is styled like the rest of boost's buttons In clean verify that it looks like it was before in stables (font size will be a little bigger) Go to 'manage calendar subscriptions' page in clean Verify the file picker button looks the same when disabled (when url is selected) as it did before the patch

For example on the 'add groups' form:

Note that we do have this rule in ur scss:

input {

    &.fp-btn-choose {

        @extend .btn-sm;

It kind of looks to me like it would bet better as .form-control-file but its not quite the same fit

Testing discovered

MDL-56964 Boost: file picker drop zone

MDL-56979 Boost: Group index form is not boosty

Participants:: Ankit Agarwal, CiBoT, Dan Poltawski, David Monllaó, Eloy Lafuente (stronk7), John Okely