Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-56911

Theme CSS [[setting:name]] fail to operate in RTL

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 3.2
    • Fix Version/s: 3.2
    • Component/s: Themes
    • Labels:
    • Testing Instructions:
      Hide

      On the "clean" theme (switch to clean properly, not using the URL ?theme=clean thing):

      Test 1

      1. Navigate to 'Site administration' -> 'Appearance' -> 'Themes' -> 'Clean'.
      2. Upload an image to the 'theme_clean:logo' setting.
      3. Navigate to the frontpage and observe the logo appearing.
      4. Switch to an RTL language.
      5. Observe that the logo appears.
        (Note there is a different issue that logo is not shifting right, I will report and fix it in a different issue)

      Test 2

      1. Add some css to theme_clean:customcss setting.
      2. Make sure the css is present in the style sheet when loading the site and it works.
      Show
      On the "clean" theme (switch to clean properly, not using the URL ?theme=clean thing): Test 1 Navigate to 'Site administration' -> 'Appearance' -> 'Themes' -> 'Clean'. Upload an image to the 'theme_clean:logo' setting. Navigate to the frontpage and observe the logo appearing. Switch to an RTL language. Observe that the logo appears. (Note there is a different issue that logo is not shifting right, I will report and fix it in a different issue) Test 2 Add some css to theme_clean:customcss setting. Make sure the css is present in the style sheet when loading the site and it works.
    • Workaround:
      Hide

      None.

      Show
      None.
    • Affected Branches:
      MOODLE_32_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE
    • Pull Master Branch:
      MDL-56911-master

      Description

      Ref: https://moodle.org/mod/forum/discuss.php?d=342787

      In the Clean theme if you upload a logo to the 'theme_clean:logo' setting, then it displays in LTR languages but not in RTL languages in the header.

      I suspect that '\lib\php-css-parser\Parser.php' is failing in the generation of the all-rtl cache file. When parsing 'theme/clean/style/custom.css' line 4 being:

          background: url([[setting:logo]]) no-repeat 0 0;
      

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  5/Dec/16