Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-56921

Atto image alignment should not be RTLed in RTL mode (theme:boost)

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Change language to one of the RTL languages (Hebrew, Arabic, ...)
      2. Navigate anywhere in a course where you can use the Atto HTML editor (i.e A forum post)
      3. Add some text (a short paragraph with a few words), at the end of the text, click the Image button on the toolbar.
      4. Find an Image, and set image alignment to RIGHT (In Hebrew it should say: "ימין"), and click "Save image"
      5. Make sure the Image is aligned to the right of the text
      6. Change language to English
      7. Go back to editing that text
      8. Double click the Image
      9. When dialog opens up, make sure the image alignment is still on the right side of the text. (and marked as "Right")
      Show
      Change language to one of the RTL languages (Hebrew, Arabic, ...) Navigate anywhere in a course where you can use the Atto HTML editor (i.e A forum post) Add some text (a short paragraph with a few words), at the end of the text, click the Image button on the toolbar. Find an Image, and set image alignment to RIGHT (In Hebrew it should say: "ימין"), and click "Save image" Make sure the Image is aligned to the right of the text Change language to English Go back to editing that text Double click the Image When dialog opens up, make sure the image alignment is still on the right side of the text. (and marked as "Right")
    • Affected Branches:
      MOODLE_32_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-56921_master

      Description

      Choosing an Image alignment using the Atto image dialog (button) should keep the selected alignment in RTL (left should be left and right should be right). it should not be flipped by the rtl CSS preprocessor for classes: "atto_image_button_right" and "atto_image_button_left"

      The basic idea is that "Content should not flip, when changed between LTR and RTL modes" (See also: MDL-45227)

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                nadavkav Nadav Kavalerchik
                Reporter:
                nadavkav Nadav Kavalerchik
                Peer reviewer:
                Dan Poltawski
                Integrator:
                David Monllaó
                Tester:
                Jake Dallimore
                Participants:
                Component watchers:
                Andrew Nicols, Mathew May, Michael Hawkins, Shamim Rezaie, Simey Lameze, Amaia Anabitarte, Bas Brands, Carlos Escobedo, Sara Arjona (@sarjona), Víctor Déniz Falcón
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  5/Dec/16