Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-56921

Atto image alignment should not be RTLed in RTL mode (theme:boost)

    XMLWordPrintable

Details

    • MOODLE_32_STABLE
    • MOODLE_32_STABLE
    • MDL-56921_master
    • Hide
      1. Change language to one of the RTL languages (Hebrew, Arabic, ...)
      2. Navigate anywhere in a course where you can use the Atto HTML editor (i.e A forum post)
      3. Add some text (a short paragraph with a few words), at the end of the text, click the Image button on the toolbar.
      4. Find an Image, and set image alignment to RIGHT (In Hebrew it should say: "ימין"), and click "Save image"
      5. Make sure the Image is aligned to the right of the text
      6. Change language to English
      7. Go back to editing that text
      8. Double click the Image
      9. When dialog opens up, make sure the image alignment is still on the right side of the text. (and marked as "Right")
      Show
      Change language to one of the RTL languages (Hebrew, Arabic, ...) Navigate anywhere in a course where you can use the Atto HTML editor (i.e A forum post) Add some text (a short paragraph with a few words), at the end of the text, click the Image button on the toolbar. Find an Image, and set image alignment to RIGHT (In Hebrew it should say: "ימין"), and click "Save image" Make sure the Image is aligned to the right of the text Change language to English Go back to editing that text Double click the Image When dialog opens up, make sure the image alignment is still on the right side of the text. (and marked as "Right")

    Description

      Choosing an Image alignment using the Atto image dialog (button) should keep the selected alignment in RTL (left should be left and right should be right). it should not be flipped by the rtl CSS preprocessor for classes: "atto_image_button_right" and "atto_image_button_left"

      The basic idea is that "Content should not flip, when changed between LTR and RTL modes" (See also: MDL-45227)

      Attachments

        Issue Links

          has a non-specific relationship to

          Improvement - An enhancement to an existing Moodle feature. MDL-45227 Add text direction to default ATTO generated markup

          • Major - Major loss of function, incorrect output
          • Closed
          Testing discovered

          Functional Test - A test of a single Moodle feature MDLQA-10155 CLONE - RTL site smoke test

          • Trivial - Cosmetic problem like misspelt words or misaligned text
          • Passed

          Activity

            People

              nadavkav Nadav Kavalerchik
              nadavkav Nadav Kavalerchik
              Dan Poltawski Dan Poltawski
              David Monllaó David Monllaó
              Jake Dallimore Jake Dallimore
              David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo, Huong Nguyen, Bas Brands, Mathew May
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                5/Dec/16