Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 3.2
-
Fix Version/s: 3.1.4
-
Component/s: Web Services
-
Testing Instructions:
-
Affected Branches:MOODLE_32_STABLE
-
Fixed Branches:MOODLE_31_STABLE
-
Pull from Repository:
-
Pull Master Branch:
MDL-56958-master -
Pull Master Diff URL:
Description
When calling the ajax webservice script - /lib/ajax/service.php because AJAX_SCRIPT is defined, any webservice that is called will get the "_ajax" renderer by default. In any theme (boost) - unless we define an ajax renderer (can't extend the base one - needs to duplicate the whole thing) we will get the core ajax renderer which only falls back on the core_renderer (not the one from the theme).
If we are returning some HTML as part of a web-service response, we are not expecting the AJAX renderer - it does weird things like removing all headers etc. The AJAX renderer also handles custom error formatting - but we do that anyway in external_api::call_external_function.
So - anything that goes through /lib/ajax/service.php should prefer the GENERAL renderer instead.
Attachments
Issue Links
- blocks
-
MDL-56435 theme_boost: ensure competencies form elements look good
-
- Closed
-