Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 3.2
-
Fix Version/s: 3.2
-
Component/s: Themes
-
Testing Instructions:
-
Affected Branches:MOODLE_32_STABLE
-
Fixed Branches:MOODLE_32_STABLE
-
Epic Link:
-
Pull from Repository:
-
Pull Master Branch:
MDL-56959-master -
Pull Master Diff URL:
Description
This issue was identified looking at the problem described here: https://moodle.org/mod/forum/discuss.php?d=342859#p1382427
Since MDL-56078, the pre_scss callback includes the preset. Therefore, rather than prepending SCSS this callback returns the whole SCSS file. This works fine until we extend Boost. When extending Boost, both callbacks from the child and parent are called, from ancestors to descendants.
In the case described in the forum, that caused the whole SCSS to be rendered twice, and some variables not to have any effect (not sure why, but that's the case). Regardless, the pre callback does not do what it's meant to do any more as Boost includes everything from the start, and thus we can't inject anything before the main SCSS content.