[MDL-57002] Files with special characters cannot be downloaded using WebDAV - Moodle Tracker

XML

Word

Printable

Affected Branches:
MOODLE_31_STABLE
Fixed Branches:
MOODLE_31_STABLE
Pull from Repository:
git://github.com/FMCorz/moodle.git
Pull Master Branch:
~~MDL-57002~~-master
Pull Master Diff URL:
https://github.com/FMCorz/moodle/compare/b4d6669dd0...MDL-57002-master
Testing Instructions:
Hide

Set-up a WebDAV instance

Add folders and files to it

Some folders and files must have special characters in them

Confirm that you can add files with and without special characters to your private files
Show
Set-up a WebDAV instance Add folders and files to it Some folders and files must have special characters in them Confirm that you can add files with and without special characters to your private files

This was spotted testing ~~MDLQA-10379~~ and ~~MDLQA-10378~~.

When picking a file named "çø.txt", this exception comes up:

* line 1932 of /lib/filestorage/file_storage.php: file_exception thrown

* line 1487 of /lib/filestorage/file_storage.php: call to file_storage->add_file_to_pool()

* line 1335 of /repository/lib.php: call to file_storage->create_file_from_pathname()

* line 296 of /repository/repository_ajax.php: call to repository::move_to_filepool()

This may affect other repositories.

caused a regression

MDL-58372 Exception Too few arguments to function repository Moodle 3.2.2 Php 7.1.2

Discovered while testing

MDLQA-10378 CLONE - A user can access WebDav repository with basic authentication

MDLQA-10379 CLONE: A user can access WebDav repository without authentication

is a regression caused by

MDL-52217 dropbox repository does not clean up in temp download dir

Participants:: Andrew Lyons, CiBoT, Damyon Wiese, Eloy Lafuente (stronk7), Frédéric Massart, Marina Glancy, Rajesh Taneja

Component watchers:: David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo